Re: [CFT][PATCH] Re: Fwd: Re: memory usage - dentry_cache

Yoann Vandoorselaere
2001-04-12T12:43:23Z

Marcin Kowalski <kowalski@datrix.co.za> writes:

> Hi
>
> Regarding the patch ....
>
> I don't have experience with the linux kernel internals but could this patch
> not lead to a run-loop condition as the only thing that can break our of the
> for(;;) loop is the tmp==&dentry_unused statement. So if the required number
> of dentries does not exist and this condition is not satisfied we would have
> an infinate loop... sorry if this is a silly question.

AFAICT no because of the list_del_init(tmp) call :
When the list will be empty,
tmp will be equal to dentry_unused.prev (this is a circular list).

--
Yoann Vandoorselaere | "Programming is a race between programmers, who try and
MandrakeSoft | make more and more idiot-proof software, and universe,
| which produces more and more remarkable idiots. Until
| now, universe leads the race" -- R. Cook