public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: s-jaschke@t-online.de (Stefan Jaschke)
To: "J . A . Magallon" <jamagallon@able.es>,
	Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: ac10 ide-cd oopses on boot
Date: Fri, 20 Apr 2001 09:05:00 +0200	[thread overview]
Message-ID: <01042009050000.06427@antares> (raw)
In-Reply-To: <20010420004914.A1052@werewolf.able.es>
In-Reply-To: <20010420004914.A1052@werewolf.able.es>

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

On Friday 20 April 2001 00:49, J . A . Magallon wrote:
> Hi,
>
> Just built 2.4.3-ac10 and got an oops when booting. It tries to detect
> the CD and gives the oops.
> >>EIP; c01bfc7c <cdrom_get_entry+1c/50>   <=====

This appears to be a known problem. Jens Axboe sent a patch in a different
thread ("SD-W2002 DVD-RAM") that fixes this. I am including it
here for your convenience. (The patch is against 2.4.4-pre4 + Jens' 
latest fixes.) 

Stefan

\0

[-- Attachment #2: cd-get-entry-1 --]
[-- Type: text/plain, Size: 744 bytes --]

--- drivers/cdrom/cdrom.c~	Thu Apr 19 13:44:46 2001
+++ drivers/cdrom/cdrom.c	Thu Apr 19 13:45:33 2001
@@ -350,6 +350,12 @@
 {
 	int i, nr, foo;
 
+	if (!cdrom_numbers) {
+		int n_entries = CDROM_MAX_CDROMS / (sizeof(unsigned long) * 8);
+		cdrom_numbers = kmalloc(n_entries * sizeof(unsigned long), GFP_KERNEL);
+		memset(cdrom_numbers, 0, n_entries * sizeof(unsigned long));
+	}
+
 	nr = 0;
 	foo = -1;
 	for (i = 0; i < CDROM_MAX_CDROMS / (sizeof(unsigned long) * 8); i++) {
@@ -2696,10 +2702,6 @@
 
 static int __init cdrom_init(void)
 {
-	int n_entries = CDROM_MAX_CDROMS / (sizeof(unsigned long) * 8);
-
-	cdrom_numbers = kmalloc(n_entries * sizeof(unsigned long), GFP_KERNEL);
-
 #ifdef CONFIG_SYSCTL
 	cdrom_sysctl_register();
 #endif
\0

  parent reply	other threads:[~2001-04-20  7:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-04-19 22:49 ac10 ide-cd oopses on boot J . A . Magallon
2001-04-19 23:07 ` Alan Cox
2001-04-19 23:34   ` J . A . Magallon
2001-04-20  2:38     ` Bill Nottingham
2001-04-20  2:55       ` Jordan
2001-04-20 10:44         ` [lkml]Re: " thunder7
2001-04-20  0:17   ` Udo A. Steinberg
2001-04-20  0:29     ` J . A . Magallon
2001-04-20  7:05 ` Stefan Jaschke [this message]
2001-04-20  8:45   ` patch: cdrom_init not called correctly (was Re: ac10 ide-cd oopses on boot) Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01042009050000.06427@antares \
    --to=s-jaschke@t-online.de \
    --cc=jamagallon@able.es \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefan@jaschke-net.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox