public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: 2.4.5 + ReiserFS + SMP + umount = oops
@ 2001-05-27 17:38 Ed Tomlinson
  0 siblings, 0 replies; 6+ messages in thread
From: Ed Tomlinson @ 2001-05-27 17:38 UTC (permalink / raw)
  To: linux-kernel; +Cc: Rene

Hi,

This was reported on the reiserfs list yesterday.  Seems that the cleanup
applied late in  2.4.5-pre affected the locking of the umount process.  This
was posted to fix the problem.

Ed Tomlinson

-----------------------

"Vladimir V. Saveliev" wrote:
> 
> Hi
> 
> Gergely Tamas wrote:
> > 
> > Hi!
> > 
> > Kernel is 2.4.5
> > 
> > I've tried to unmount a reiserfs device (/uu.new) and got a segfault.
>
> Well, sys_umount in 2.4.5 changed to not lock_kernel() at the beginning and to not unlock_kernel() at the end correspondingly.
> journal_begin expectes kernel locked and it oopses when it is not. Maybe reiserfs_put_super should lock_kernel () itself?
> 


Hi,

You are right.
It seems, the next patch can fix umount reiserfs bug in linux-2.4.5 :

diff -urN v2.4.5/fs/reiserfs/super.c linux/fs/reiserfs/super.c
--- v2.4.5/fs/reiserfs/super.c   Sun Apr 29 16:02:25 2001
+++ linux/fs/reiserfs/super.c    Sat May 26 19:10:16 2001
@@ -104,7 +104,8 @@
 {
   int i;
   struct reiserfs_transaction_handle th ;
-  
+
+  lock_kernel() ;  
   /* change file system state to current state if it was mounted with
read-write permissions */
   if (!(s->s_flags & MS_RDONLY)) {
     journal_begin(&th, s, 10) ;
@@ -117,6 +118,7 @@
   ** to do a journal_end
   */
   journal_release(&th, s) ;
+  unlock_kernel() ;
 
   for (i = 0; i < SB_BMAP_NR (s); i ++)
     brelse (SB_AP_BITMAP (s)[i]);



Thanks,
Yura.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* 2.4.5 + ReiserFS + SMP + umount = oops
@ 2001-05-27  3:10 Rene
  2001-05-27  3:44 ` Keith Owens
  0 siblings, 1 reply; 6+ messages in thread
From: Rene @ 2001-05-27  3:10 UTC (permalink / raw)
  To: linux-kernel

Hi list :)

I just upgraded an SMP-machine from 2.4.4 to 2.4.5.
It's a 
2xPII@300MHz 
Asus P2B-D motherboard 
128mb RAM.
unknown PCI gfx-card
Promise ATA-100 IDE-controller

Problem #1
I have 2 disk on the ATA-controller (30 and 45GB - both IBM) running a
Reiser-partition each.
I can do reiserfsck and debugreiserfs just fine and get an 'ok' back from
both ('ok' from fsck and 'VALID' from debug..). I can mount the
reiser-partitions, but - when I umount the first partition I get:
# umount /stuff (/dev/hde1)
journal_begin called without kernel lock held
kernel BUG at journal.c:423!
invalid operand: 0000
CPU:    0
EIP:    0010:[<c01813d0>]
EFLAGS: 00010282
eax: 0000001d   ebx: c1ea5f28   ecx: 00000001   edx: 00000001
esi: c6104e00   edi: 3b105b44   ebp: 0000000a   esp: c1ea5ec0
ds: 0018   es: 0018   ss: 0018
Process umount (pid: 9217, stackpage=c1ea5000)
Stack: c022210c c02222a4 000001a7 c018395f c02232c1 c1ea5f28 c6104e00
c0250220
       c6104e34 3b105b44 00000000 c5eada60 c1ea4000 c6104e00 c1ea4000
c0183b6a
       c1ea5f28 c6104e00 0000000a 00000000 c0174728 c1ea5f28 c6104e00
0000000a
Call Trace: [<c018395f>] [<c0183b6a>] [<c0174728>] [<c0138b3a>]
[<c0138b71>] [<c0137e1c>] [<c013de6c>]
       [<c013901d>] [<c0124052>] [<c0139054>] [<c0106ceb>]

Code: 0f 0b 83 c4 0c c3 89 f6 31 c0 c3 90 31 c0 c3 90 56 be 00 f3


I took a look at fs/reiserfs/journal.c and compared (diff) it to the same
file from 2.4.4 and found the line where the message is generated (line
423). The problem is that a diff on those two journal.c's revealed no
difference whatsoever which leads me to the conclusion that this bug might
not have so much to do with ReiserFS afterall.

These things worked fine in 2.4.4 btw.
back in 2.4.2 I followed the Changes and did an upgrade to binutils,
e2fsprogs and util-linux, and these upgrades should still be ok.


Problem #2
Certain keystrokes like ctrl+c does not work when logged in from the
console - only when logged in throuhg ssh. This is really not that
important as the machine only acts as a monitor-less fileserver.



If You need additional information - please let me know.

regards
  /Rene 



-- 
Rene Mikkelsen, 
Tlf: +45 40501985
---------------------------------------------------------------
http://www.eslug.dk - the choice of a GNU generation
http://dustpuppy.dk - UF på dansk
---------------------------------------------------------------


^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2001-05-27 17:38 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-05-27 17:38 2.4.5 + ReiserFS + SMP + umount = oops Ed Tomlinson
  -- strict thread matches above, loose matches on Subject: below --
2001-05-27  3:10 Rene
2001-05-27  3:44 ` Keith Owens
2001-05-27  4:04   ` Rene
2001-05-27  4:11     ` Keith Owens
2001-05-27  4:28       ` Rene

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox