From: Daniel Phillips <phillips@bonn-fries.net>
To: rjd@xyzzy.clara.co.uk, phillips@bonn-fries.net (Daniel Phillips)
Cc: jgarzik@mandrakesoft.com (Jeff Garzik),
bpringle@sympatico.ca (Bill Pringlemeir),
linux-kernel@vger.kernel.org
Subject: Re: Newbie idiotic questions.
Date: Sun, 17 Jun 2001 17:01:10 +0200 [thread overview]
Message-ID: <0106171701100P.00879@starship> (raw)
In-Reply-To: <200106171227.f5HCRZu10829@xyzzy.clara.co.uk>
In-Reply-To: <200106171227.f5HCRZu10829@xyzzy.clara.co.uk>
On Sunday 17 June 2001 14:27, rjd@xyzzy.clara.co.uk wrote:
> Daniel Phillips wrote:
> > > because then you would be allocating the size of a pointer, not the
> > > size of a structure
> >
> > Whoops Jeff, you didn't have your coffee yet:
>
> Whoops yourself. The following patch brings your example into line with
> the driver code. mpuout is a pointer to a structure not the structure
> itself as the malloc assignment clearly indicates.
Yep, the only thing left to resolve is whether Jeff had coffee or not. ;-)
- if ((card->mpuout = kmalloc(sizeof(struct emu10k1_mpuout), GFP_KERNEL))
+ if ((card->mpuout = kmalloc(sizeof(*card->mpuout), GFP_KERNEL))
--
Daniel
next prev parent reply other threads:[~2001-06-17 14:58 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-17 1:19 Newbie idiotic questions Bill Pringlemeir
2001-06-17 1:32 ` Jeff Garzik
2001-06-17 10:48 ` Daniel Phillips
2001-06-17 12:27 ` rjd
2001-06-17 15:01 ` Daniel Phillips [this message]
2001-06-17 15:08 ` Jeff Garzik
2001-06-17 15:38 ` David Flynn
2001-06-17 15:54 ` Jeff Garzik
2001-06-17 19:18 ` Geert Uytterhoeven
2001-06-17 20:08 ` Daniel Phillips
2001-06-17 20:37 ` Alexander Viro
2001-06-17 21:28 ` Daniel Phillips
2001-06-17 22:33 ` Alexander Viro
2001-06-18 9:14 ` Roman Zippel
2001-06-18 9:30 ` Alexander Viro
2001-06-17 21:17 ` Bill Pringlemeir
2001-06-17 1:35 ` Richard B. Johnson
2001-06-17 3:01 ` Arnaldo Carvalho de Melo
2001-06-17 8:06 ` rjd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0106171701100P.00879@starship \
--to=phillips@bonn-fries.net \
--cc=bpringle@sympatico.ca \
--cc=jgarzik@mandrakesoft.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjd@xyzzy.clara.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox