public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Phillips <phillips@bonn-fries.net>
To: BERECZ Szabolcs <szabi@inf.elte.hu>,
	Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: kswapd eats the cpu without swap
Date: Tue, 7 Aug 2001 01:21:33 +0200	[thread overview]
Message-ID: <01080701213301.02122@starship> (raw)
In-Reply-To: <Pine.A41.4.31.0108070044550.37910-100000@pandora.inf.elte.hu>
In-Reply-To: <Pine.A41.4.31.0108070044550.37910-100000@pandora.inf.elte.hu>

On Tuesday 07 August 2001 00:48, BERECZ Szabolcs wrote:
> On Fri, 3 Aug 2001, Marcelo Tosatti wrote:
> > Does the problem happen only with the used-once patch ?
> >
> > If it also happens without the used-once patch, can you reproduce
> > the problem with 2.4.6 ?
>
> The problem happened about 4 times, with the used-once patch,
> but I don't know exactly what triggered it.
>
> now I use 2.4.7-ac5, and I have not seen the problem, yet.
>
> I will try with the used-once patch, if it appears again.

Please note the additional patch, to be applied after the used-once 
patch for 2.4.7 and 2.4.7-ac*, or directly to 2.4.8-pre*.  This was 
posted on lkml and linux-mm on Aug 5 under the subject:

    [PATCH] Unlazy activate

which adds the additional behaviour of moving used-twice pages to the 
active list.

Here it is again:

--- ../2.4.7.clean/mm/filemap.c	Sat Aug  4 14:27:16 2001
+++ ./mm/filemap.c	Sat Aug  4 23:41:00 2001
@@ -979,9 +979,13 @@
 
 static inline void check_used_once (struct page *page)
 {
-	if (!page->age) {
-		page->age = PAGE_AGE_START;
-		ClearPageReferenced(page);
+	if (!PageActive(page)) {
+		if (page->age)
+			activate_page(page);
+		else {
+			page->age = PAGE_AGE_START;
+			ClearPageReferenced(page);
+		}
 	}
 }
 

  reply	other threads:[~2001-08-06 23:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-08-01 22:08 kswapd eats the cpu without swap BERECZ Szabolcs
2001-08-01 22:23 ` BERECZ Szabolcs
2001-08-01 22:58   ` BERECZ Szabolcs
2001-08-02  9:38     ` Peter Wächtler
2001-08-02 10:49       ` Helge Hafting
2001-08-03 22:21 ` Marcelo Tosatti
2001-08-06 22:48   ` BERECZ Szabolcs
2001-08-06 23:21     ` Daniel Phillips [this message]
2001-08-06 22:47       ` Marcelo Tosatti
  -- strict thread matches above, loose matches on Subject: below --
2001-08-02 20:47 BERECZ Szabolcs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01080701213301.02122@starship \
    --to=phillips@bonn-fries.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo@conectiva.com.br \
    --cc=szabi@inf.elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox