From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030346AbdEXK0Z (ORCPT ); Wed, 24 May 2017 06:26:25 -0400 Received: from foss.arm.com ([217.140.101.70]:35944 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934016AbdEXK0T (ORCPT ); Wed, 24 May 2017 06:26:19 -0400 Subject: Re: [PATCH] ARM: dts: rockchip: correct regular setting for act8846 To: Heiko Stuebner , Eddie Cai Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@armlinux.org.uk, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org References: <1495611221-6749-1-git-send-email-eddie.cai.linux@gmail.com> <5352430.FzU3E8oYou@phil> From: Robin Murphy Message-ID: <010ca6dc-e1f7-fb6d-7a22-056d4e1eeef2@arm.com> Date: Wed, 24 May 2017 11:26:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <5352430.FzU3E8oYou@phil> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 24/05/17 09:17, Heiko Stuebner wrote: > Hi Eddie, > > Am Mittwoch, 24. Mai 2017, 15:33:41 CEST schrieb Eddie Cai: >> the previous setting of act8846 is just copy from firefly board. but >> the reload board is a little different from firefly board. let's correct >> it. >> >> Signed-off-by: Eddie Cai >> --- >> arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 21 +++++++++++---------- >> 1 file changed, 11 insertions(+), 10 deletions(-) >> >> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi >> index 8134966..4cfa109 100644 >> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi >> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi >> @@ -179,6 +179,7 @@ >> regulator-name = "vccio_sd"; >> regulator-min-microvolt = <3300000>; >> regulator-max-microvolt = <3300000>; >> + regulator-always-on; > > the rest below looks pretty straight forward, but why does vccio_sd > need to be always on? > > I've checked the reload's schematics but did not find any further users > of vccio_sd that may warant this attribute. It looks like the card detect line is pulled up externally to vcc_sd, which isn't always-on either, so you probably do want this - on the (unrelated) rk3288 TV box I've been hacking on, I discovered that powering off the sdmmc-supply domain also kills the internal pull-up and leaves sdmmc_cd floating. The resulting stochastic card polling mechanism is amusing, but probably undesirable ;) Robin. > > > Heiko > > >> }; >> >> vdd10_lcd: REG6 { >> @@ -187,24 +188,23 @@ >> regulator-max-microvolt = <1000000>; >> }; >> >> - vcca_18: REG7 { >> - regulator-name = "vcca_18"; >> - regulator-min-microvolt = <1800000>; >> - regulator-max-microvolt = <1800000>; >> - regulator-always-on; >> + vcca_33: REG7 { >> + regulator-name = "vcca_33"; >> + regulator-min-microvolt = <3300000>; >> + regulator-max-microvolt = <3300000>; >> }; >> >> - vcca_33: REG8 { >> - regulator-name = "vcca_33"; >> + vcc_lan: REG8 { >> + regulator-name = "vcc_lan"; >> regulator-min-microvolt = <3300000>; >> regulator-max-microvolt = <3300000>; >> - regulator-always-on; >> }; >> >> - vcc_lan: REG9 { >> - regulator-name = "vcca_lan"; >> + vccio_pmu: REG9 { >> + regulator-name = "vccio_pmu"; >> regulator-min-microvolt = <3300000>; >> regulator-max-microvolt = <3300000>; >> + regulator-always-on; >> }; >> >> vdd_10: REG10 { >> @@ -218,6 +218,7 @@ >> regulator-name = "vcc_18"; >> regulator-min-microvolt = <1800000>; >> regulator-max-microvolt = <1800000>; >> + regulator-always-on; >> }; >> >> vcc18_lcd: REG12 { >> > > > > _______________________________________________ > linux-arm-kernel mailing list > linux-arm-kernel@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel >