From: Krzysztof Kozlowski <krzk@kernel.org>
To: Flavio Suligoi <f.suligoi@asem.it>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Jose Abreu <joabreu@synopsys.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-msm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/6] arm64: dts: qcom: sa8540p-ride: remove tx-sched-sp property
Date: Fri, 5 Apr 2024 17:51:59 +0200 [thread overview]
Message-ID: <010d67c7-ca71-43fc-a3e3-ec3e5cd8b149@kernel.org> (raw)
In-Reply-To: <20240405152800.638461-6-f.suligoi@asem.it>
On 05/04/2024 17:27, Flavio Suligoi wrote:
> The property "tx-sched-sp" no longer exists, as it was removed from the
> file:
>
> drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c
>
> by the commit:
>
> commit aed6864035b1 ("net: stmmac: platform: Delete a redundant condition
> branch")
Same problem with commit. BTW, your commit msg does not say what happens
if this property is removed. Instead it could be "Strict priority is by
default in Linux driver and tx-sched-sp was removed in commit sha ("foo
bar")".
With fixed in commit msg.
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-04-05 15:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 15:27 [PATCH 0/6] Remove stmmac tx-sched-sp property from documentation and DT Flavio Suligoi
2024-04-05 15:27 ` [PATCH 1/6] dt-bindings: net: snps,dwmac: remove tx-sched-sp property Flavio Suligoi
2024-04-05 15:49 ` Krzysztof Kozlowski
2024-04-05 15:50 ` Krzysztof Kozlowski
2024-04-10 14:46 ` EXTERNAL: " FLAVIO SULIGOI
2024-04-05 15:27 ` [PATCH 2/6] arm64: dts: imx8mp-beacon: " Flavio Suligoi
2024-04-05 15:27 ` [PATCH 3/6] arm64: dts: imx8mp-evk: " Flavio Suligoi
2024-04-05 15:27 ` [PATCH 4/6] arm64: dts: imx8mp-verdin: " Flavio Suligoi
2024-04-05 15:27 ` [PATCH 5/6] arm64: dts: qcom: sa8540p-ride: " Flavio Suligoi
2024-04-05 15:51 ` Krzysztof Kozlowski [this message]
2024-04-05 15:28 ` [PATCH 6/6] dts: qcom: sa8775p-ride: " Flavio Suligoi
2024-04-05 15:52 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=010d67c7-ca71-43fc-a3e3-ec3e5cd8b149@kernel.org \
--to=krzk@kernel.org \
--cc=alexandre.torgue@foss.st.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=f.suligoi@asem.it \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=peppe.cavallaro@st.com \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox