public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Patch to sys_shmdt
@ 2001-10-11 20:20 Adam Bottchen
  0 siblings, 0 replies; only message in thread
From: Adam Bottchen @ 2001-10-11 20:20 UTC (permalink / raw)
  To: linux-kernel; +Cc: torvalds

	Currently sys_shmdt() always returns success.  Below is a patch that changes
 this behavior to match the man page.  This patch will cause sys_shmdt() to 
return success only when it finds something to detach, and returns EINVAL 
otherwise.  The patch was run on a 2.4.10 kernel tree, but applies against a 2.4.12
tree with no problems.


--- linux-2.4.10old/ipc/shm.c   Fri Oct  5 11:53:12 2001
+++ linux-2.4.10/ipc/shm.c      Fri Oct  5 15:08:51 2001
@@ -649,16 +649,19 @@
 {
        struct mm_struct *mm = current->mm;
        struct vm_area_struct *shmd, *shmdnext;
+       int retcode=-EINVAL;

        down_write(&mm->mmap_sem);
        for (shmd = mm->mmap; shmd; shmd = shmdnext) {
                shmdnext = shmd->vm_next;
                if (shmd->vm_ops == &shm_vm_ops
-                   && shmd->vm_start - (shmd->vm_pgoff << PAGE_SHIFT) == (ulong) shmaddr)
+                   && shmd->vm_start - (shmd->vm_pgoff << PAGE_SHIFT) == (ulong) shmaddr) {
                        do_munmap(mm, shmd->vm_start, shmd->vm_end - shmd->vm_start);
+                       retcode=0;
+               }
        }
        up_write(&mm->mmap_sem);
-       return 0;
+       return retcode;
 }

 #ifdef CONFIG_PROC_FS


Adam Bottchen
bottchen@earthlink.net

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2001-10-11 20:20 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2001-10-11 20:20 Patch to sys_shmdt Adam Bottchen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox