Re: [PATCH] Remove needless BKL from release functions

Flavio Stanchina
2001-11-26T19:42:41Z

On Monday 26 November 2001 18:46, David C. Hansen wrote:

> In the patch, in the open function, you do this:
> if (handler)
> new_fops = fops_get(handler->fops);
>
> But, the fops_get() #define already cheecks to make sure handler isn't
> null: #define fops_get(fops) \
> (((fops) && (fops)->owner) \
> ? ( try_inc_mod_count((fops)->owner) ? (fops) : NULL ) \
> : (fops))

Look closer, it doesn't check 'handler' (it couldn't).

--
Ciao,
Flavio Stanchina
Trento - Italy

"The best defense against logic is ignorance."