From: "Alim Akhtar" <alim.akhtar@samsung.com>
To: "'sheebab'" <sheebab@cadence.com>, <avri.altman@wdc.com>,
<pedrom.sousa@synopsys.com>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <stanley.chu@mediatek.com>,
<beanhuo@micron.com>, <yuehaibing@huawei.com>,
<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<vigneshr@ti.com>
Cc: <mparab@cadence.com>, <rafalc@cadence.com>
Subject: RE: [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS
Date: Tue, 3 Dec 2019 16:01:18 +0530 [thread overview]
Message-ID: <011201d5a9c4$d0f99780$72ecc680$@samsung.com> (raw)
In-Reply-To: <1575367635-22662-1-git-send-email-sheebab@cadence.com>
> -----Original Message-----
> From: sheebab <sheebab@cadence.com>
> Sent: 03 December 2019 15:37
> To: alim.akhtar@samsung.com; avri.altman@wdc.com;
> pedrom.sousa@synopsys.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com; stanley.chu@mediatek.com;
> beanhuo@micron.com; yuehaibing@huawei.com; linux-scsi@vger.kernel.org;
> linux-kernel@vger.kernel.org; vigneshr@ti.com
> Cc: mparab@cadence.com; rafalc@cadence.com; sheebab
> <sheebab@cadence.com>
> Subject: [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS
>
> This patch disables autohibern8 feature in Cadence UFS.
> The autohibern8 feature has issues due to which unexpected interrupt
trigger is
> happening. After the interrupt issue is sorted out autohibern8 feature
will be re-
> enabled
>
> Signed-off-by: sheebab <sheebab@cadence.com>
> ---
Probably we want to mark this as FIX for the older kernel version?
Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com>
> drivers/scsi/ufs/cdns-pltfrm.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/scsi/ufs/cdns-pltfrm.c
b/drivers/scsi/ufs/cdns-pltfrm.c index
> b2af04c57a39..882425d1166b 100644
> --- a/drivers/scsi/ufs/cdns-pltfrm.c
> +++ b/drivers/scsi/ufs/cdns-pltfrm.c
> @@ -98,6 +98,12 @@ static int cdns_ufs_link_startup_notify(struct ufs_hba
> *hba,
> * completed.
> */
> ufshcd_dme_set(hba, UIC_ARG_MIB(PA_LOCAL_TX_LCC_ENABLE), 0);
> +
> + /*
> + * Disabling Autohibern8 feature in cadence UFS
> + * to mask unexpected interrupt trigger.
> + */
> + hba->ahit = 0;
>
> return 0;
> }
> --
> 2.17.1
next prev parent reply other threads:[~2019-12-03 10:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191203100929epcas3p3e781cc87ff70f82bc1e708ba654456d2@epcas3p3.samsung.com>
2019-12-03 10:07 ` [PATCH] scsi: ufs: Disable autohibern8 feature in Cadence UFS sheebab
2019-12-03 10:31 ` Alim Akhtar [this message]
2019-12-04 13:36 ` Vignesh Raghavendra
2019-12-10 0:05 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='011201d5a9c4$d0f99780$72ecc680$@samsung.com' \
--to=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=mparab@cadence.com \
--cc=pedrom.sousa@synopsys.com \
--cc=rafalc@cadence.com \
--cc=sheebab@cadence.com \
--cc=stanley.chu@mediatek.com \
--cc=vigneshr@ti.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox