From: 김기웅 <kwmad.kim@samsung.com>
To: "'Bean Huo'" <huobean@gmail.com>, <linux-scsi@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <alim.akhtar@samsung.com>,
<avri.altman@wdc.com>, <bvanassche@acm.org>, <jejb@linux.ibm.com>,
<martin.petersen@oracle.com>, <beanhuo@micron.com>,
<adrian.hunter@intel.com>, <h10.kim@samsung.com>,
<hy50.seo@samsung.com>, <sh425.lee@samsung.com>,
<kwangwon.min@samsung.com>, <junwoo80.lee@samsung.com>,
<wkon.kim@samsung.com>
Subject: RE: [PATCH v2 0/2] scsi: ufs: introduce a callback to override OCS value
Date: Tue, 27 Aug 2024 14:51:35 +0900 [thread overview]
Message-ID: <011201daf845$2d7846e0$8868d4a0$@samsung.com> (raw)
In-Reply-To: <04306da77d74e16edab1d682a8602f61b35025a3.camel@gmail.com>
> +static enum utp_ocs exynos_ufs_override_cqe_ocs(enum utp_ocs ocs) {
> + if (ocs == OCS_ABORTED)
> + ocs = OCS_INVALID_COMMAND_STATUS;
> + return ocs;
> +}
>
>
> I wonder if you have considered the case where the command is aborted
> by the host software or by the device itself?
I mean by the host software and Exynos host reports OCS_ABORTED only for the case when MCQ is enabled.
>
> If you change OCS to OCS_INVALID_COMMAND_STATUS, there will report a
> DID_REQUEUE to SCSI.
Yes. That's what I meant, in order to process them properly after UFS initialization.
>
>
> Kind regards,
> Bean
Thank you.
prev parent reply other threads:[~2024-08-27 5:51 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20240822111247epcas2p2d3051255f42af05fd049b7247c395da4@epcas2p2.samsung.com>
2024-08-22 11:15 ` [PATCH v2 0/2] scsi: ufs: introduce a callback to override OCS value Kiwoong Kim
2024-08-22 11:15 ` [PATCH v2 1/2] scsi: ufs: core: introduce override_cqe_ocs Kiwoong Kim
2024-08-26 13:08 ` kernel test robot
2024-08-22 11:15 ` [PATCH v2 2/2] scsi: ufs: ufs-exynos: implement override_cqe_ocs Kiwoong Kim
2024-08-22 14:54 ` [PATCH v2 0/2] scsi: ufs: introduce a callback to override OCS value Bean Huo
2024-08-22 16:23 ` Bart Van Assche
2024-08-27 5:59 ` Kiwoong Kim
2024-08-22 15:42 ` Bean Huo
2024-08-22 16:26 ` Bart Van Assche
2024-09-02 0:27 ` Kiwoong Kim
2024-08-27 5:51 ` 김기웅 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='011201daf845$2d7846e0$8868d4a0$@samsung.com' \
--to=kwmad.kim@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=alim.akhtar@samsung.com \
--cc=avri.altman@wdc.com \
--cc=beanhuo@micron.com \
--cc=bvanassche@acm.org \
--cc=h10.kim@samsung.com \
--cc=huobean@gmail.com \
--cc=hy50.seo@samsung.com \
--cc=jejb@linux.ibm.com \
--cc=junwoo80.lee@samsung.com \
--cc=kwangwon.min@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sh425.lee@samsung.com \
--cc=wkon.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox