From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F3A7C33C99 for ; Tue, 7 Jan 2020 05:46:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 496E42070E for ; Tue, 7 Jan 2020 05:46:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="NYuOjV05" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727209AbgAGFqr (ORCPT ); Tue, 7 Jan 2020 00:46:47 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:56089 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725267AbgAGFqr (ORCPT ); Tue, 7 Jan 2020 00:46:47 -0500 Received: from epcas5p4.samsung.com (unknown [182.195.41.42]) by mailout2.samsung.com (KnoxPortal) with ESMTP id 20200107054644epoutp023c414efe4b2349caf535b49e833433f8~nhJ0Ywa-c2797727977epoutp02I for ; Tue, 7 Jan 2020 05:46:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20200107054644epoutp023c414efe4b2349caf535b49e833433f8~nhJ0Ywa-c2797727977epoutp02I DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1578376004; bh=rpOmXMQDMiEUV6h4gsMF/DhyY6RdP2+VJxeu30CnrSU=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=NYuOjV05+wf5uc24waEK6SjkWgJrIidj9N4iI6mu5rtZ+y0np0h9Sk/5FEKiEF6qM D4maHdke0klXP3zzWEzOD+yyAaZ2EttQ7ZOQgFUFDUy0LFqMU0YQtWkLuMIJqzyoq7 c4/H7w4+wv5/2HS5Xk8moU4KUfq1z2Wn5kae2H/w= Received: from epsmges5p3new.samsung.com (unknown [182.195.42.75]) by epcas5p1.samsung.com (KnoxPortal) with ESMTP id 20200107054644epcas5p12fe67744d0af78cec03d2e9438149164~nhJzz7Bgk1340813408epcas5p12; Tue, 7 Jan 2020 05:46:44 +0000 (GMT) Received: from epcas5p2.samsung.com ( [182.195.41.40]) by epsmges5p3new.samsung.com (Symantec Messaging Gateway) with SMTP id 2D.76.19629.34B141E5; Tue, 7 Jan 2020 14:46:43 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas5p3.samsung.com (KnoxPortal) with ESMTPA id 20200107054643epcas5p35ce5b5080632d7d8859ea5ec375df993~nhJzVd2740753307533epcas5p3g; Tue, 7 Jan 2020 05:46:43 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20200107054643epsmtrp1e194a228dd825c313e8a7c4a84b6da71~nhJzUgyZa2258722587epsmtrp1n; Tue, 7 Jan 2020 05:46:43 +0000 (GMT) X-AuditID: b6c32a4b-345ff70000014cad-86-5e141b43b04a Received: from epsmtip1.samsung.com ( [182.195.34.30]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id AA.B1.10238.34B141E5; Tue, 7 Jan 2020 14:46:43 +0900 (KST) Received: from sriramdash03 (unknown [107.111.85.29]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20200107054639epsmtip181dafcd142890c0ec4992e6f172b2ea2~nhJvJtYl_2651326513epsmtip1Q; Tue, 7 Jan 2020 05:46:38 +0000 (GMT) From: "Sriram Dash" To: "'Florian Fainelli'" , Cc: , , "'David S. Miller'" , , , , "'Jayati Sahu'" , "'Padmanabhan Rajanbabu'" , , "'Jose Abreu'" , "'Alexandre Torgue'" , , "'Maxime Coquelin'" , "'Giuseppe Cavallaro'" , , , , , In-Reply-To: <20200107050846.16838-1-f.fainelli@gmail.com> Subject: RE: [PATCH net] Revert "net: stmmac: platform: Fix MDIO init for platforms without PHY" Date: Tue, 7 Jan 2020 11:16:36 +0530 Message-ID: <011a01d5c51d$d7482290$85d867b0$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Content-Language: en-in Thread-Index: AQI1ZYvsFetxt2LSxnoGVL5lXWNB8wDUcl0vpxjJvRA= X-Brightmail-Tracker: H4sIAAAAAAAAA02SaUxTURCFvX1LH0v1tYCO4Nq4GwSjJNcloNGYZ9zDDxNjilVfwAiVtICg cUVAiyBKlFqxcUGCSF1KsaDWBcEFgiIoQQkoUiQUUQGjVFG0fTXy75uZc+bcSS5DyLJpf2ab Ko5Xq5TRctqTvPlw+rTAJQG+iuDv6QvwDVs1widbbTTOfX6IxEVN5Qj/+FQhxh97LxJ48H0X hSuq8kS4ZeALhR1pZhE2tTVQuP5WLo21DTYKG34ZKZzakiPGj86NxJU3wvGFkq9iPNhVgrC+ tpTCmcY6epEf97kxRcyVNuchznz5tYgr0zeLOVPhEZorztvHZZoLEWdpMBDcg7uzufZ+K8GZ 7/Uhrs80bq33Bs+FW/nobQm8Oih0k2fUQHI2HXvNL9HwxEDvRzVSLfJggJ0L6Z21SIs8GRl7 G0FyzhuRUPQieF34gRCKbwg+Xb2H/lkcpTq3xYrAduaF22JHcCmvX+xU0Wwg1DQepJ3syy6H jrNZrlUEa6Wgs93uGniw86HubTfpZB92M/zKd7jMJDsJBvJ1lJMl7DzoOdknFlgKT0/bXHqC HQ+W7lxCeNIEcLTnU0J/FFQ6jhJC8Hx4ZqwnncHApjCQVpXsNiyFQWsrLbAP2B+bxQL7Q+ex VDdvh/rMDrc+DnT286TAYXD/Ze5fZv6GTYdrt4KE3OGQ8dMmcraBlcDhVJmgngz2pmL3xgC4 b6wWCcxB55NqOgtN1A+5TD/kMv2Qa/T/w84hshCN5mM1MZG8JiR2jorfOUujjNHEqyJnbdkR Y0KurzpjRSkyPVtZjlgGyb0lWWN8FDJKmaBJiilHwBByX8mBZVKFTLJVmbSLV++IUMdH85py FMCQ8lGSE9SrjTI2UhnHb+f5WF79bypiPPz3o8Ts1ou7Q+8UGI/1eYeOp9Thxaf85V0zLel+ Eb+vR4QcP2xRzDmSs1fbdCWl3ZGhU8SpdPaeomGrbHavXbW95Iuxe6MSg1unBa1Ok05ZF+b1 zlhgnWr5UrMUL9zUtmZ9XdHi782GU2XLZ2aE9X8r6d7Sk8iHSBNGl2nv7jkvkQ6OiJaTmijl 7BmEWqP8A+Gt7WWmAwAA X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRzGe3duczg4bpqvDiyGRVlTF314s4hSiEN9KPBLFqkHd7zgNsc5 aimRq8zIRLog6ZJhNSTNYd5ymbaal9TQQkGU0somJV7TJBdb5hyR3348z/N/eD78xZhsCQ8V Z+izOV7PapWkBH/WqQxTxSkCE6NXCxWowfkWoLIvThJVvivEUd0HB0C/57soNLv0CENrkzME 6uq3iNCEe5FAruvNItT4dYRAw22VJCoecRLI7LESqGjiHoV6qrai7oZ49LDlJ4XWZloAMr23 EajUOkQeCWIWRq9RjG3cApjmmjER89w0TjGNtTdIpslSwJQ21wKmdcSMMa9fqpmp1Q6MabYv A2a5MeyU/xnJIQ2nzcjl+KjDyZJ099W7pKE+6IK510wawUBAMfATQ3o/dNnKgZdl9AsA+41k MRCv6wroGlf5InJY8+cbVQwk65HvAPYtDlJeg6RVcGD0CunlQPoEdNoXCG8IowcI2GL8LPKV 3gTQOpvpZT86Bg59msO9LKeTYUdFEeFlnA6H7uryDZbSB+CPsmXKxwGwr8KJewdhdCQsatjY idHbYOtcJeYbtx26pqoJnx4Mu10lmG9PDBy0DuO3gNy0qcn0v8m0qcm06boK4LUghDMIujSd oDao9dz5SIHVCTn6tMiULF0j2PiEiN02MGxJcgBaDJT+UhQqT5QRbK6Qp3MAKMaUgdLLxwIS ZVINm5fP8VlJfI6WExxAIcaVwdIpfU+CjE5js7lMjjNw/D9XJPYLNQJV6tmeCk07Jt3zpv5g tXY6vm02JaRPPTJfsqjZksEm84mz4VHuIUmTQdUbPLYjll2JnuzvvP+4/aknNvVi99Hl4+aP hvHYvIJygrfvZDxWgdpbm4D23bbPaQnFq12eeA354E5r3LlfTZcmT1fmN9UpolqMYSf51ZVp k8P6RIkL6aw6AuMF9i8WEZclBQMAAA== X-CMS-MailID: 20200107054643epcas5p35ce5b5080632d7d8859ea5ec375df993 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P X-CMS-RootMailID: 20200107050854epcas1p3c1a66e67f14802322063f6c9747f1986 References: <20200107050846.16838-1-f.fainelli@gmail.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Florian Fainelli > Subject: [PATCH net] Revert "net: stmmac: platform: Fix MDIO init for platforms > without PHY" > > This reverts commit d3e014ec7d5ebe9644b5486bc530b91e62bbf624 ("net: > stmmac: platform: Fix MDIO init for platforms without PHY") because it breaks > existing systems with stmmac which do not have a MDIO bus sub-node nor a > 'phy-handle' property declared in their Device Tree. On those systems, the > stmmac MDIO bus is expected to be created and then scanned by > of_mdiobus_register() to create PHY devices. > > While these systems should arguably make use of a more accurate Device Tree > reprensentation with the use of the MDIO bus sub-node an appropriate 'phy- > handle', we cannot break them, therefore restore the behavior prior to the said > commit. > > Fixes: d3e014ec7d5e ("net: stmmac: platform: Fix MDIO init for platforms > without PHY") > Reported-by: Heiko Stuebner > Reported-by: kernelci.org bot > Signed-off-by: Florian Fainelli Nacked-by: Sriram Dash > --- > Heiko, > > I did not add the Tested-by because the patch is a little bit different from what > you tested, even if you most likely were not hitting the other part that I was > changing. Thanks! > > drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > index cc8d7e7bf9ac..bedaff0c13bd 100644 > --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_platform.c > @@ -320,7 +320,7 @@ static int stmmac_mtl_setup(struct platform_device > *pdev, static int stmmac_dt_phy(struct plat_stmmacenet_data *plat, > struct device_node *np, struct device *dev) { > - bool mdio = false; > + bool mdio = true; This is breaking for the platforms with fixed-link. stih418-b2199.dts and 169445.dts to name a few. For the newer platforms, they should provide the mdio/ snps,dwmac-mdio property in the device tree as we are checking the mdio/ snps,dwmac-mdio property in the stmmac_platform driver for the mdio bus memory allocation. For existing platforms, I agree we should not break them, but we should make the code correct. And make the existing platforms adapt to the proper code. There is a proposed solution. https://lkml.org/lkml/2020/1/7/14 What do you think? > static const struct of_device_id need_mdio_ids[] = { > { .compatible = "snps,dwc-qos-ethernet-4.10" }, > {}, > -- > 2.19.1