[PATCH] mce: acpi/apei: Only disable banks listed in HEST if mce is configured

[PATCH] mce: acpi/apei: Only disable banks listed in HEST if mce is configured

[Luck, Tony]

From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>

Randconfig testing found this error:
>> hest.c(.init.text+0x6004): undefined reference to 'mce_disable_bank'

Fix by wrapping body of hest_parse_cmc() inside #ifdef CONFIG_X86_MCE

Reported-by: "Wu, Fengguang" <fengguang.wu@intel.com>
Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
Signed-off-by: Tony Luck <tony.luck@intel.com>
---

[Peter: Thanks for pulling Naveen's series from my ras tree. Fengguang's
 testbuild robot promtly found this build issue. Please apply this patch
 on top of the x86/mce branch. - Thanks]

 drivers/acpi/apei/hest.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
index 5020245..f5e37f3 100644
--- a/drivers/acpi/apei/hest.c
+++ b/drivers/acpi/apei/hest.c
@@ -128,6 +128,7 @@ EXPORT_SYMBOL_GPL(apei_hest_parse);
  */
 static int __init hest_parse_cmc(struct acpi_hest_header *hest_hdr, void *data)
 {
+#ifdef CONFIG_X86_MCE
 	int i;
 	struct acpi_hest_ia_corrected *cmc;
 	struct acpi_hest_ia_error_bank *mc_bank;
@@ -152,7 +153,7 @@ static int __init hest_parse_cmc(struct acpi_hest_header *hest_hdr, void *data)
 	mc_bank = (struct acpi_hest_ia_error_bank *)(cmc + 1);
 	for (i = 0; i < cmc->num_hardware_banks; i++, mc_bank++)
 		mce_disable_bank(mc_bank->bank_number);
-
+#endif
 	return 1;
 }
 
-- 
1.8.1.4

Re: [PATCH] mce: acpi/apei: Only disable banks listed in HEST if mce is configured

[Borislav Petkov]

On Fri, Jul 19, 2013 at 09:50:15AM -0700, Luck, Tony wrote:
> From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
> 
> Randconfig testing found this error:
> >> hest.c(.init.text+0x6004): undefined reference to 'mce_disable_bank'
> 
> Fix by wrapping body of hest_parse_cmc() inside #ifdef CONFIG_X86_MCE
> 
> Reported-by: "Wu, Fengguang" <fengguang.wu@intel.com>
> Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
> Signed-off-by: Tony Luck <tony.luck@intel.com>

> ---
> 
> [Peter: Thanks for pulling Naveen's series from my ras tree. Fengguang's
>  testbuild robot promtly found this build issue. Please apply this patch
>  on top of the x86/mce branch. - Thanks]

This one still needs picking up since randconfig builds fail. hpa, can
you apply to tip:x86/mce please?

Thanks.

-- 
Regards/Gruss,
    Boris.

Sent from a fat crate under my desk. Formatting is fine.
--