public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
To: "Chaoyi Chen" <chaoyi.chen@rock-chips.com>,
	"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
	"Maxime Ripard" <mripard@kernel.org>,
	"Thomas Zimmermann" <tzimmermann@suse.de>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>,
	"Sandy Huang" <hjc@rock-chips.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Andy Yan" <andy.yan@rock-chips.com>,
	"Louis Chauvet" <louis.chauvet@bootlin.com>,
	"Haneen Mohammed" <hamohammed.sa@gmail.com>,
	"Melissa Wen" <melissa.srw@gmail.com>
Cc: Robert Mader <robert.mader@collabora.com>,
	kernel@collabora.com, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH v3 4/4] drm/rockchip: vop2: Support setting custom background color
Date: Sat, 20 Dec 2025 00:42:05 +0200	[thread overview]
Message-ID: <012994e7-0e69-4885-8050-a404b7ae7608@collabora.com> (raw)
In-Reply-To: <292ed476-2b5a-4b61-97e5-3b8d8a24c324@rock-chips.com>

On 11/30/25 5:01 AM, Chaoyi Chen wrote:
> On 11/29/2025 5:50 PM, Cristian Ciocaltea wrote:
>> Hi Chaoyi,
>>
>> On 11/29/25 5:49 AM, Chaoyi Chen wrote:
>>> Hello Cristian, 
>>>
>>> On 11/28/2025 5:44 PM, Cristian Ciocaltea wrote:
>>>> The precision was something I initially looked into for CRC verification, in the
>>>> context of the related IGT test.  But since I've added the VKMS support, I think
>>>> we should not worry about that anymore. 
>>>>
>>>> Moreover, as already pointed out in [1], only RK3576 supports CRC generation at
>>>> display controller level, and that is not particularly useful because it doesn't
>>>
>>> I believe you can get the CRTC CRC on the RK3576, even when only the 
>>> background is visible and all plane is disabled. Feel free to let me
>>> know if you run into any issues :)
>>
>> Yes, CRTC CRC works on RK3576 for the planes, but not for the background, i.e.
>> the CRC is not updated when setting a different background color.  Unless
>> there's a way to change this default behavior, which I'm not aware of. 
>>
>> My current understanding is that the background color is applied at a later
>> stage in the display pipeline, *after* blending the planes and computing CRC.
>>
> 
> Which CRTC are you using? If you're using VP0, you might run into this
> problem. Please try VP1 instead.

Yeah, that's VP0 as there's only one HDMI output port on my Radxa ROCK 4D board.
I'll check if it's possible to switch to VP1.

  reply	other threads:[~2025-12-19 22:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-17 23:51 [PATCH v3 0/4] Introduce BACKGROUND_COLOR DRM CRTC property Cristian Ciocaltea
2025-11-17 23:51 ` [PATCH v3 1/4] uapi: Provide DIV_ROUND_CLOSEST() Cristian Ciocaltea
2025-11-17 23:52 ` [PATCH v3 2/4] drm: Add CRTC background color property Cristian Ciocaltea
2025-11-17 23:52 ` [PATCH v3 3/4] drm/vkms: Support setting custom background color Cristian Ciocaltea
2025-11-17 23:52 ` [PATCH v3 4/4] drm/rockchip: vop2: " Cristian Ciocaltea
2025-11-28  8:46   ` Chaoyi Chen
2025-11-28  9:44     ` Cristian Ciocaltea
2025-11-29  3:49       ` Chaoyi Chen
2025-11-29  9:50         ` Cristian Ciocaltea
2025-11-30  3:01           ` Chaoyi Chen
2025-12-19 22:42             ` Cristian Ciocaltea [this message]
2025-12-19 22:33       ` Cristian Ciocaltea
2026-01-07 12:18 ` [PATCH v3 0/4] Introduce BACKGROUND_COLOR DRM CRTC property Diederik de Haas
2026-01-07 17:54   ` Cristian Ciocaltea
2026-01-07 19:37   ` Diederik de Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=012994e7-0e69-4885-8050-a404b7ae7608@collabora.com \
    --to=cristian.ciocaltea@collabora.com \
    --cc=airlied@gmail.com \
    --cc=andy.yan@rock-chips.com \
    --cc=chaoyi.chen@rock-chips.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hamohammed.sa@gmail.com \
    --cc=heiko@sntech.de \
    --cc=hjc@rock-chips.com \
    --cc=kernel@collabora.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=melissa.srw@gmail.com \
    --cc=mripard@kernel.org \
    --cc=robert.mader@collabora.com \
    --cc=simona@ffwll.ch \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox