* [PATCH 1/2] f2fs: remove obsolete code
@ 2015-02-25 21:47 Jaegeuk Kim
2015-02-25 21:47 ` [PATCH 2/2] f2fs: avoid wrong error during recovery Jaegeuk Kim
0 siblings, 1 reply; 3+ messages in thread
From: Jaegeuk Kim @ 2015-02-25 21:47 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, linux-f2fs-devel; +Cc: Jaegeuk Kim
This patch removes obsolete code in which summary variable is not needed.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/recovery.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index 188a034..b2a92d4 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -407,8 +407,6 @@ static int do_recover_data(struct f2fs_sb_info *sbi, struct inode *inode,
dn.ofs_in_node++;
}
- /* write node page in place */
- set_summary(&sum, dn.nid, 0, 0);
if (IS_INODE(dn.node_page))
sync_inode_page(&dn);
--
2.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH 2/2] f2fs: avoid wrong error during recovery
2015-02-25 21:47 [PATCH 1/2] f2fs: remove obsolete code Jaegeuk Kim
@ 2015-02-25 21:47 ` Jaegeuk Kim
2015-02-26 1:15 ` [f2fs-dev] " Chao Yu
0 siblings, 1 reply; 3+ messages in thread
From: Jaegeuk Kim @ 2015-02-25 21:47 UTC (permalink / raw)
To: linux-kernel, linux-fsdevel, linux-f2fs-devel; +Cc: Jaegeuk Kim
From: Jaegeuk Kim <jaegeuk@motorola.com>
During the roll-forward recovery, -ENOENT for f2fs_iget can be skipped.
So, this error value should not be propagated.
Change-Id: I230ad2371e3fb4b9df42059c4a61f92c1f9838de
Signed-off-by: Jaegeuk Kim <jaegeuk@motorola.com>
---
fs/f2fs/recovery.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/fs/f2fs/recovery.c b/fs/f2fs/recovery.c
index b2a92d4..6e40874 100644
--- a/fs/f2fs/recovery.c
+++ b/fs/f2fs/recovery.c
@@ -212,8 +212,10 @@ static int find_fsync_dnodes(struct f2fs_sb_info *sbi, struct list_head *head)
if (IS_ERR(entry->inode)) {
err = PTR_ERR(entry->inode);
kmem_cache_free(fsync_entry_slab, entry);
- if (err == -ENOENT)
+ if (err == -ENOENT) {
+ err = 0;
goto next;
+ }
break;
}
list_add_tail(&entry->list, head);
--
2.1.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* RE: [f2fs-dev] [PATCH 2/2] f2fs: avoid wrong error during recovery
2015-02-25 21:47 ` [PATCH 2/2] f2fs: avoid wrong error during recovery Jaegeuk Kim
@ 2015-02-26 1:15 ` Chao Yu
0 siblings, 0 replies; 3+ messages in thread
From: Chao Yu @ 2015-02-26 1:15 UTC (permalink / raw)
To: 'Jaegeuk Kim', linux-kernel, linux-fsdevel,
linux-f2fs-devel
Cc: 'Jaegeuk Kim'
> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Thursday, February 26, 2015 5:47 AM
> To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org;
> linux-f2fs-devel@lists.sourceforge.net
> Cc: Jaegeuk Kim
> Subject: [f2fs-dev] [PATCH 2/2] f2fs: avoid wrong error during recovery
>
> From: Jaegeuk Kim <jaegeuk@motorola.com>
>
> During the roll-forward recovery, -ENOENT for f2fs_iget can be skipped.
> So, this error value should not be propagated.
>
> Change-Id: I230ad2371e3fb4b9df42059c4a61f92c1f9838de
> Signed-off-by: Jaegeuk Kim <jaegeuk@motorola.com>
Reviewed-by: Chao Yu <chao2.yu@samsung.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-02-26 1:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-02-25 21:47 [PATCH 1/2] f2fs: remove obsolete code Jaegeuk Kim
2015-02-25 21:47 ` [PATCH 2/2] f2fs: avoid wrong error during recovery Jaegeuk Kim
2015-02-26 1:15 ` [f2fs-dev] " Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox