public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 2/2] f2fs: update inode page under cp_rwsem lock
@ 2016-02-25  9:44 Chao Yu
  0 siblings, 0 replies; only message in thread
From: Chao Yu @ 2016-02-25  9:44 UTC (permalink / raw)
  To: Jaegeuk Kim; +Cc: linux-f2fs-devel, linux-kernel

We should update inode page under protection of cp_rwsem lock, otherwise
new dirty inode pages will generated by ->fsync or ->write_inode during
checkpoint, which should not be allowed.

Signed-off-by: Chao Yu <chao2.yu@samsung.com>
---
 fs/f2fs/inode.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/fs/f2fs/inode.c b/fs/f2fs/inode.c
index cb269c4..cdfe114 100644
--- a/fs/f2fs/inode.c
+++ b/fs/f2fs/inode.c
@@ -295,6 +295,7 @@ retry:
 int f2fs_write_inode(struct inode *inode, struct writeback_control *wbc)
 {
 	struct f2fs_sb_info *sbi = F2FS_I_SB(inode);
+	bool updated;
 
 	if (inode->i_ino == F2FS_NODE_INO(sbi) ||
 			inode->i_ino == F2FS_META_INO(sbi))
@@ -307,7 +308,11 @@ int f2fs_write_inode(struct inode *inode, struct writeback_control *wbc)
 	 * We need to balance fs here to prevent from producing dirty node pages
 	 * during the urgent cleaning time when runing out of free sections.
 	 */
-	if (update_inode_page(inode))
+	f2fs_lock_op(sbi);
+	updated = update_inode_page(inode);
+	f2fs_unlock_op(sbi);
+
+	if (updated)
 		f2fs_balance_fs(sbi, true);
 	return 0;
 }
-- 
2.7.0

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2016-02-25  9:45 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-02-25  9:44 [PATCH 2/2] f2fs: update inode page under cp_rwsem lock Chao Yu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox