From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752639AbcBOJEr (ORCPT ); Mon, 15 Feb 2016 04:04:47 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:44300 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752548AbcBOJEg (ORCPT ); Mon, 15 Feb 2016 04:04:36 -0500 X-AuditID: cbfee61a-f79266d000003652-b2-56c194a29972 From: Chao Yu To: "'Jaegeuk Kim'" Cc: tytso@mit.edu, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <00fe01d16716$5ec0a540$1c41efc0$@samsung.com> In-reply-to: <00fe01d16716$5ec0a540$1c41efc0$@samsung.com> Subject: RE: [f2fs-dev] [PATCH 5/7] f2fs crypto: set up encryption info for new inodes in f2fs_inherit_context() Date: Mon, 15 Feb 2016 17:03:51 +0800 Message-id: <013601d167cf$e3e37180$abaa5480$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQH/xbvNYbojv7u8EmJxx3/F4RQpxp7QEitQ Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrHLMWRmVeSWpSXmKPExsVy+t9jAd3FUw6GGXS+Z7R4sn4Ws8WlRe4W l3fNYbNo7fnJ7sDisWlVJ5vH7gWfmTyazhxl9vi8SS6AJYrLJiU1J7MstUjfLoErY86WV6wF HWIVN/oOsTcwvhHqYuTkkBAwkWhdv4MZwhaTuHBvPVsXIxeHkMBSRonW/kWMEM4rRom2h3cZ QarYBFQklnf8ZwKxRQTUJHr3TQGzmQUiJaZ8n8IKYgsJWEpc+bEGbCqngJXE062NYL3CAkUS P+80sIPYLAKqEu1zvoPV8ALVr/nSxgJhC0r8mHyPBWKmlsTmbU2sELa8xOY1b6EuVZDYcfY1 I8QNRhKz2p6wQ9SIS2w8cotlAqPQLCSjZiEZNQvJqFlIWhYwsqxilEgtSC4oTkrPNcxLLdcr TswtLs1L10vOz93ECI6FZ1I7GA/ucj/EKMDBqMTDG3HmQJgQa2JZcWXuIUYJDmYlEd5nrQfD hHhTEiurUovy44tKc1KLDzFKc7AoifM+/r8uTEggPbEkNTs1tSC1CCbLxMEp1cDo27cj82Jm xu2zL38xHNsz9VLEwo2H43nTrz9YFWX9T/lnzpTDV6TeyvEtiK6d0/nT+KK5pOOdSY5bXfT+ Zf19Ynh5SVXqwrPbZgnY3PHwncJSe3/uNttuxXNtuU8rH90SVDW9cza55YT5hu2hZ3zkjsRo N4Z84TrBWLhT5KbTa/3+k8nXjFznKLEUZyQaajEXFScCAPXB9saBAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, Please ignore this patch because it incurs deadlock as below: bit_wait_io+0x1f/0x60 __wait_on_bit_lock+0x5c/0xb0 __lock_page+0xba/0xd0 pagecache_get_page+0x187/0x230 __get_node_page+0x7d/0x200 [f2fs] get_node_page+0x12/0x20 [f2fs] read_all_xattrs+0x213/0x330 [f2fs] f2fs_getxattr+0x86/0x140 [f2fs] _f2fs_get_encryption_info+0xb4/0x4d0 [f2fs] f2fs_inherit_context+0xf8/0x100 [f2fs] init_inode_metadata+0xb3/0x410 [f2fs] __f2fs_add_link+0x2e1/0x650 [f2fs] f2fs_mkdir+0xdb/0x180 [f2fs] vfs_mkdir+0xe5/0x160 SyS_mkdirat+0xb8/0xf0 SyS_mkdir+0x19/0x20 entry_SYSCALL_64_fastpath+0x12/0x6f Thanks, > -----Original Message----- > From: Chao Yu [mailto:chao2.yu@samsung.com] > Sent: Sunday, February 14, 2016 6:56 PM > To: Jaegeuk Kim > Cc: tytso@mit.edu; linux-kernel@vger.kernel.org; linux-f2fs-devel@lists.sourceforge.net > Subject: [f2fs-dev] [PATCH 5/7] f2fs crypto: set up encryption info for new inodes in > f2fs_inherit_context() > > This patch syncs f2fs with commit 555570295532 ("ext4 crypto: set up > encryption info for new inodes in ext4_inherit_context()") from ext4. > > Set up the encryption information for newly created inodes immediately > after they inherit their encryption context from their parent > directories. > > Signed-off-by: Theodore Ts'o > Signed-off-by: Chao Yu > --- > fs/f2fs/crypto_policy.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/fs/f2fs/crypto_policy.c b/fs/f2fs/crypto_policy.c > index d4a96af..0fb08b0 100644 > --- a/fs/f2fs/crypto_policy.c > +++ b/fs/f2fs/crypto_policy.c > @@ -203,7 +203,10 @@ int f2fs_inherit_context(struct inode *parent, struct inode *child, > F2FS_KEY_DESCRIPTOR_SIZE); > > get_random_bytes(ctx.nonce, F2FS_KEY_DERIVATION_NONCE_SIZE); > - return f2fs_setxattr(child, F2FS_XATTR_INDEX_ENCRYPTION, > + res = f2fs_setxattr(child, F2FS_XATTR_INDEX_ENCRYPTION, > F2FS_XATTR_NAME_ENCRYPTION_CONTEXT, &ctx, > sizeof(ctx), ipage, XATTR_CREATE); > + if (!res) > + res = f2fs_get_encryption_info(child); > + return res; > } > -- > 2.7.0.2.g1b0b6dd > > > > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=272487151&iu=/4140 > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel