From: "Rini van Zetten" <rini@arvoo.nl>
To: <afleming@freescale.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: [PATCH]drivers/net/phy/: default return value in ioctl phy.c
Date: Tue, 11 Dec 2007 16:02:31 +0100 [thread overview]
Message-ID: <014901c83c06$da9223e0$2b00a8c0@ARV127> (raw)
Hello Andy,
This patch (to 2.6.23.9) add a default return value EOPNOTSUPP to the ioctl
function. The problem with the always 0 return value is that the iwconfig
(wireless) tool found a valid device when an ethernet device uses the phy
abstraction layer.
I 've tetsted this with the macb driver.
Signed-off-by: Rini van Zetten <rini@arvoo.nl>
diff --git a/drivers/net/phy/phy.c b/drivers/net/phy/phy.c
index cb230f4..c07460d 100644
--- a/drivers/net/phy/phy.c
+++ b/drivers/net/phy/phy.c
@@ -405,6 +405,8 @@ int phy_mii_ioctl(struct phy_device *phydev,
&& phydev->drv->config_init)
phydev->drv->config_init(phydev);
break;
+ default:
+ return -EOPNOTSUPP;
}
return 0;
next reply other threads:[~2007-12-11 15:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-11 15:02 Rini van Zetten [this message]
2008-01-14 18:48 ` [PATCH]drivers/net/phy/: default return value in ioctl phy.c Andy Fleming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='014901c83c06$da9223e0$2b00a8c0@ARV127' \
--to=rini@arvoo.nl \
--cc=afleming@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox