Re: [PATCH 5/8] reset: amlogic: add reset status support

Stephen Boyd
2024-07-10T22:40:18Z

Quoting Jerome Brunet (2024-07-10 09:25:14)
> Add a callback to check the status of the level reset, as done in
> the reset driver of the audio clock controller.

Why? Presumably so that this driver has equivalent functionality to the
reset code in the audio clk controller?

>
> Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
> ---
> drivers/reset/reset-meson.c | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
> index 3e0447366ba6..65ba9190cb53 100644
> --- a/drivers/reset/reset-meson.c
> +++ b/drivers/reset/reset-meson.c
> @@ -69,6 +69,23 @@ static int meson_reset_level(struct reset_controller_dev *rcdev,
> BIT(bit), assert ? BIT(bit) : 0);
> }
>
> +static int meson_reset_status(struct reset_controller_dev *rcdev,
> + unsigned long id)
> +{
> + struct meson_reset *data =
> + container_of(rcdev, struct meson_reset, rcdev);

Nitpick: One line.

> + unsigned int val, offset, bit;
> +
> + meson_reset_offset_and_bit(data, id, &offset, &bit);
> + offset += data->param->level_offset;
> +
> + regmap_read(data->map, offset, &val);
> + val = !!(BIT(bit) & val);
> +
> +

Nitpick: Drop the extra newline?

> + return val ^ data->param->level_low_reset;
> +}
> +
> static int meson_reset_assert(struct reset_controller_dev *rcdev,
> unsigned long id)