Re: [PATCH 0/8] reset: amlogic: move audio reset drivers out of CCF

Jan Dakinevich
2024-07-15T22:46:29Z

Jerome, I have tested the series on SM1 SoC (Amlogic AC200 ref board).
As far as I can tell, it works as it should

On 7/10/24 19:25, Jerome Brunet wrote:
> This patchset follows the discussion about having reset driver in the
> clock tree [1]. Ideally those should reside in the reset part of tree.
>
> Also the code of the amlogic reset driver is very similar between the 2
> trees and could use the same driver code.
>
> This patchset moves the reset driver of audio clock controller of the
> g12 and sm1 SoC family to the reset tree, using the auxiliary bus.
>
> The infrastructure put in place is meant to be generic enough so we may
> eventually also move the reset drivers in the meson8b and aoclk clock
> controllers.
>
> Change since RFC [2]:
> * Move the aux registration helper out of clock too.
>
> [1] https://lore.kernel.org/linux-clk/e3a85852b911fdf16dd9ae158f42b3ef.sboyd@kernel.org
> [2] https://lore.kernel.org/linux-clk/20240516150842.705844-1-jbrunet@baylibre.com
>
> Jerome Brunet (8):
> reset: amlogic: convert driver to regmap
> reset: amlogic: add driver parameters
> reset: amlogic: split the device and platform probe
> reset: amlogic: use reset number instead of register count
> reset: amlogic: add reset status support
> reset: amlogic: add toggle reset support
> reset: amlogic: add auxiliary reset driver support
> clk: amlogic: axg-audio: use the auxiliary reset driver
>
> drivers/clk/meson/Kconfig | 1 +
> drivers/clk/meson/axg-audio.c | 109 +-------
> drivers/reset/Kconfig | 1 +
> drivers/reset/reset-meson.c | 285 ++++++++++++++++----
> include/soc/amlogic/meson-auxiliary-reset.h | 23 ++
> 5 files changed, 271 insertions(+), 148 deletions(-)
> create mode 100644 include/soc/amlogic/meson-auxiliary-reset.h
>

--
Best regards
Jan Dakinevich