From: "Florian Schirmer" <jolt@tuxbox.org>
To: "Linus Torvalds" <torvalds@osdl.org>, <armin@melware.de>
Cc: "Kernel Mailing List" <linux-kernel@vger.kernel.org>,
<i4ldeveloper@listserv.isdn4linux.de>
Subject: Re: Linux 2.6.6-rc3
Date: Wed, 28 Apr 2004 11:16:07 +0200 [thread overview]
Message-ID: <015701c42d01$70886260$9602010a@jingle> (raw)
In-Reply-To: Pine.LNX.4.58.0404271858290.10799@ppc970.osdl.org
Hi,
> Armin Schindler:
> o ISDN CAPI: add ncci list semaphore
This looks broken for !CONFIG_ISDN_CAPI_MIDDLEWARE configs. Note the up()
inside the #ifdef.
@@ -904,13 +917,17 @@
if (copy_from_user((void *)&ncci, (void *)arg,
sizeof(ncci)))
return -EFAULT;
- nccip = capincci_find(cdev, (u32) ncci);
- if (!nccip)
+
+ down(&cdev->ncci_list_sem);
+ if ((nccip = capincci_find(cdev, (u32) ncci)) == 0) {
+ up(&cdev->ncci_list_sem);
return 0;
+ }
#ifdef CONFIG_ISDN_CAPI_MIDDLEWARE
if ((mp = nccip->minorp) != 0) {
count += atomic_read(&mp->ttyopencount);
}
+ up(&cdev->ncci_list_sem);
#endif /* CONFIG_ISDN_CAPI_MIDDLEWARE */
return count;
}
Regards,
Florian
next prev parent reply other threads:[~2004-04-28 9:16 UTC|newest]
Thread overview: 57+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-28 2:03 Linux 2.6.6-rc3 Linus Torvalds
2004-04-28 8:48 ` Måns Rullgård
2004-04-28 9:16 ` Florian Schirmer [this message]
2004-04-28 9:52 ` Armin Schindler
2004-04-28 11:56 ` Eyal Lebedinsky
2004-05-01 11:24 ` 2.6.6-rc3: gcc 2.95: cx88 __ucmpdi2 error Adrian Bunk
2004-05-01 17:45 ` Linus Torvalds
2004-05-01 18:38 ` Andreas Schwab
2004-05-01 18:57 ` Linus Torvalds
2004-05-04 17:13 ` Gerd Knorr
2004-05-01 20:13 ` 2.6.6-rc3: modular DVB tda1004x broken Adrian Bunk
2004-05-01 22:02 ` Johannes Stezenbach
2004-05-01 22:14 ` Andrew Morton
2004-05-01 22:37 ` Linus Torvalds
2004-05-01 23:10 ` Andrew Morton
2004-05-01 23:55 ` Linus Torvalds
2004-05-02 0:00 ` Chris Wedgwood
2004-05-02 0:03 ` Andrew Morton
2004-05-02 0:28 ` Linus Torvalds
2004-05-02 0:51 ` Andrew Morton
2004-05-02 1:16 ` Paul Mackerras
2004-05-03 18:06 ` David Mosberger
2004-05-03 18:20 ` Linus Torvalds
2004-05-03 18:30 ` David Mosberger
2004-05-03 18:37 ` Linus Torvalds
2004-05-03 20:42 ` Linus Torvalds
2004-05-03 20:56 ` David Mosberger
2004-05-03 21:07 ` Arjan van de Ven
2004-05-03 22:39 ` David Mosberger
2004-05-04 7:55 ` Arjan van de Ven
2004-05-04 16:44 ` David Mosberger
2004-05-04 16:47 ` Arjan van de Ven
2004-05-03 21:02 ` Andrew Morton
2004-05-03 21:06 ` Arjan van de Ven
2004-05-03 21:16 ` viro
2004-05-03 21:24 ` Jörn Engel
2004-05-03 21:54 ` viro
2004-05-03 22:01 ` viro
2004-05-03 22:33 ` Jörn Engel
2004-05-04 0:14 ` viro
2004-05-04 9:23 ` Jörn Engel
2004-05-04 12:13 ` Stephen Smalley
2004-04-28 14:34 ` Linux 2.6.6-rc3 (compile stats) John Cherry
2004-04-28 17:28 ` Linux 2.6.6-rc3 Maciej Soltysiak
2004-04-29 1:02 ` Craig Thomas
2004-04-29 0:59 ` CaT
2004-04-29 17:10 ` Craig Thomas
2004-04-29 2:11 ` Andrew Morton
2004-04-29 15:59 ` Craig Thomas
2004-04-29 17:01 ` Jacek Kawa
2004-04-29 17:32 ` Sam Ravnborg
2004-04-30 1:05 ` Jacek Kawa
[not found] <1PMQ9-5K6-3@gated-at.bofh.it>
2004-04-28 14:48 ` Vincent C Jones
2004-04-28 16:00 ` Sam Ravnborg
2004-04-28 17:24 ` Jari Ruusu
2004-04-28 19:08 ` Sam Ravnborg
2004-04-28 19:18 ` Vincent C Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='015701c42d01$70886260$9602010a@jingle' \
--to=jolt@tuxbox.org \
--cc=armin@melware.de \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox