From: "Martin Frey" <frey@scs.ch>
To: "'Alan Cox'" <alan@lxorguk.ukuu.org.uk>, <zippel@linux-m68k.org>,
<tigran@veritas.com>, <hch@caldera.de>, <asun@cobaltnet.com>,
<mikulas@artax.karlin.mff.cuni.cz>, <jffs-dev@axis.com>,
<dwmw2@infradead.org>, <trond.myklebust@fys.uio.no>,
<aia21@cus.cam.ac.uk>, <reiserfs-dev@namesys.com>
Cc: <baettig@scs.ch>, <linux-kernel@vger.kernel.org>
Subject: [PATCH] large offset llseek breaks for device special files on ac series
Date: Tue, 19 Jun 2001 19:24:22 -0400 [thread overview]
Message-ID: <015e01c0f916$f9e33e30$0100007f@SCHLEPPDOWN> (raw)
In-Reply-To: <E15CSrl-0006jf-00@the-village.bc.nu>
[-- Attachment #1: Type: text/plain, Size: 1355 bytes --]
Dear all,
The ac-kernel series include a check in default_llseek()
to not set the file position beyond the file systems
maximum file size.
This check should be done only for regular files, e.g. for
a device special file the test does not make sense.
Alan suggested that we remove the check from
the default_llseek method and introduce a
generic_file_llseek() method that checks the maximum
file size. The generic_file_llseek() method needs
to be put in all file systems in order to test
for the maximum file size.
I send the mail with the patch to all maintainers
of file systems, please comment.
Here is the patch. I put the generic_file_llseek
into adfs, affs, bfs, coda, ext2, fat, free_vxfs,
hfs, hpfs, jffs, jffs2, minix, ncpfs, nfs,
ntfs, openpromfs, qnx4, ramfs, reiserfs, smbfs,
sysv, and udf.
hfs got two additional llseek methods for the
metadata, same for openpromfs.
The patch applies to 2.4.5 ac 16.
The cmsfs directory produces an object file with
the wrong name, the patch fixes the cmsfs/Makefile
do produce the right object file.
Especially the hfs and openpromfs modifications
should be checked.
I did not touch the other file systems, there is
either no file read or write, or a fix is not
straight forward. I did not modifiy the proc file system,
the llseek problem should be fixed there in a more
general way.
Regards, Martin
[-- Attachment #2: patch-fs.2.4.5.ac16.gz --]
[-- Type: application/x-gzip, Size: 2748 bytes --]
next parent reply other threads:[~2001-06-19 23:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E15CSrl-0006jf-00@the-village.bc.nu>
2001-06-19 23:24 ` Martin Frey [this message]
2001-06-20 5:53 ` [PATCH] large offset llseek breaks for device special files on ac series Martin Frey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='015e01c0f916$f9e33e30$0100007f@SCHLEPPDOWN' \
--to=frey@scs.ch \
--cc=aia21@cus.cam.ac.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=asun@cobaltnet.com \
--cc=baettig@scs.ch \
--cc=dwmw2@infradead.org \
--cc=hch@caldera.de \
--cc=jffs-dev@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.frey@compaq.com \
--cc=mikulas@artax.karlin.mff.cuni.cz \
--cc=reiserfs-dev@namesys.com \
--cc=tigran@veritas.com \
--cc=trond.myklebust@fys.uio.no \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox