From: "Tokunori Ikegami" <ikegami.t@gmail.com>
To: "'Liu Jian'" <liujian56@huawei.com>, <dwmw2@infradead.org>,
<computersforpeace@gmail.com>, <bbrezillon@kernel.org>,
<marek.vasut@gmail.com>, <richard@nod.at>,
<joakim.tjernlund@infinera.com>, <ikegami@allied-telesis.co.jp>,
<keescook@chromium.org>, <vigneshr@ti.com>
Cc: <linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer
Date: Thu, 28 Feb 2019 23:25:54 +0900 [thread overview]
Message-ID: <016001d4cf71$865e7b60$931b7220$@gmail.com> (raw)
In-Reply-To: <1551189648-58073-1-git-send-email-liujian56@huawei.com>
> -----Original Message-----
> From: linux-mtd [mailto:linux-mtd-bounces@lists.infradead.org] On Behalf
> Of Liu Jian
> Sent: Tuesday, February 26, 2019 11:01 PM
> To: dwmw2@infradead.org; computersforpeace@gmail.com;
> bbrezillon@kernel.org; marek.vasut@gmail.com; richard@nod.at;
> joakim.tjernlund@infinera.com; ikegami@allied-telesis.co.jp;
> keescook@chromium.org; vigneshr@ti.com
> Cc: linux-mtd@lists.infradead.org; liujian56@huawei.com;
> linux-kernel@vger.kernel.org
> Subject: [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer
>
> In function do_write_buffer(), in the for loop, there is a case
> chip_ready() returns 1 while chip_good() returns 0, so it never
> break the loop.
> To fix this, chip_good() is enough and it should timeout if it stay
> bad for a while.
>
> Fixes: dfeae1073583("mtd: cfi_cmdset_0002: Change write buffer to check
> correct value")
> Signed-off-by: Yi Huaijie <yihuaijie@huawei.com>
> Signed-off-by: Liu Jian <liujian56@huawei.com>
> Reviewed-by: Tokunori Ikegami <ikegami_to@yahoo.co.jp>
> ---
> v2->v3:
> Follow Vignesh's advice:
> add one more check for check_good() even when time_after() returns true.
>
> drivers/mtd/chips/cfi_cmdset_0002.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/chips/cfi_cmdset_0002.c
> b/drivers/mtd/chips/cfi_cmdset_0002.c
> index 72428b6..3da2376 100644
> --- a/drivers/mtd/chips/cfi_cmdset_0002.c
> +++ b/drivers/mtd/chips/cfi_cmdset_0002.c
> @@ -1876,7 +1876,7 @@ static int __xipram do_write_buffer(struct map_info
> *map, struct flchip *chip,
> continue;
> }
>
> - if (time_after(jiffies, timeo) && !chip_ready(map, adr))
> + if (time_after(jiffies, timeo) && !chip_good(map, adr,
> datum))
Just another idea to understand easily.
unsigned long now = jiffies;
if (chip_good(map, adr, datum)) {
xip_enable(map, chip, adr);
goto op_done;
}
if (time_after(now, timeo) {
break;
}
Regards,
Ikegami
> break;
>
> if (chip_good(map, adr, datum)) {
> --
> 2.7.4
>
>
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
next prev parent reply other threads:[~2019-02-28 14:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-26 14:00 [PATCH v3] cfi: fix deadloop in cfi_cmdset_0002.c do_write_buffer Liu Jian
2019-02-28 14:25 ` Tokunori Ikegami [this message]
2019-02-28 15:12 ` liujian (CE)
2019-02-28 15:42 ` Boris Brezillon
[not found] ` <005a01d4d03e$39b0e0f0$ad12a2d0$@yahoo.co.jp>
2019-03-01 16:07 ` Boris Brezillon
2019-03-01 16:54 ` Tokunori Ikegami
2019-03-01 16:47 ` Vignesh Raghavendra
2019-03-01 16:59 ` Tokunori Ikegami
2019-03-01 17:43 ` Boris Brezillon
[not found] ` <001c01d4d057$f68572e0$e39058a0$@yahoo.co.jp>
2019-03-02 8:57 ` Vignesh Raghavendra
2019-03-01 19:56 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='016001d4cf71$865e7b60$931b7220$@gmail.com' \
--to=ikegami.t@gmail.com \
--cc=bbrezillon@kernel.org \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ikegami@allied-telesis.co.jp \
--cc=joakim.tjernlund@infinera.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=liujian56@huawei.com \
--cc=marek.vasut@gmail.com \
--cc=richard@nod.at \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox