From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756955AbcBQIq0 (ORCPT ); Wed, 17 Feb 2016 03:46:26 -0500 Received: from mailout4.samsung.com ([203.254.224.34]:49809 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756621AbcBQIqZ (ORCPT ); Wed, 17 Feb 2016 03:46:25 -0500 X-AuditID: cbfee61b-f793c6d00000236c-60-56c4335faef8 From: Chao Yu To: Jaegeuk Kim Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] f2fs: detect error of update_dent_inode in ->rename Date: Wed, 17 Feb 2016 16:45:44 +0800 Message-id: <016f01d1695f$af48abc0$0dda0340$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=US-ASCII Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AdFpX12LWnlw+v7QQVq0YEPY0jQ4Lw== Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t9jAd144yNhBsf/61k8WT+L2eLSIneL y7vmsDkwe2xa1cnmsXvBZyaPz5vkApijuGxSUnMyy1KL9O0SuDJu7/vGVnCZteLh6flsDYwH WboYOTgkBEwkrs9I7mLkBDLFJC7cW8/WxcjFISSwlFFi78kpLBDOK0aJ79smMIFUsQmoSCzv +A9miwDZhxZdZgexmQU8JBo7vrOC2MJA9s/Gj2wgNouAqsT7nRvA4rwClhIfT6+CsgUlfky+ xwLRqyWxeVsTK4QtL7F5zVtmiIsUJHacfc0IsUtPYtvZXVD14hIbj9ximcAoMAvJqFlIRs1C MmoWkpYFjCyrGCVSC5ILipPSc43yUsv1ihNzi0vz0vWS83M3MYKD+Jn0DsbDu9wPMQpwMCrx 8K7IOhwmxJpYVlyZe4hRgoNZSYS3WO9ImBBvSmJlVWpRfnxRaU5q8SFGaQ4WJXHex//XhQkJ pCeWpGanphakFsFkmTg4pRoY+a/0rUtJZnrrXfhpKtcDie+TKvm+XjpYqZE7X7zmx5bM3Ot1 akxOetnFc1U3vIsyOvFTM9NzV05Hc9FCgepdqtKnLraW3Jnofz13f9/93CKLq/Fbp0ocXHnn 3PGz+y77mVpus3PaUiOw/2JvdkX8n7OV7mu3v+fJPntVx95DTfWfvIPWo2fblViKMxINtZiL ihMBCYU+7F4CAAA= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Should check and show correct return value of update_dent_inode in ->rename. Signed-off-by: Chao Yu --- fs/f2fs/namei.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/f2fs/namei.c b/fs/f2fs/namei.c index 6f944e5..99ed009 100644 --- a/fs/f2fs/namei.c +++ b/fs/f2fs/namei.c @@ -654,8 +654,9 @@ static int f2fs_rename(struct inode *old_dir, struct dentry *old_dentry, if (err) goto put_out_dir; - if (update_dent_inode(old_inode, new_inode, - &new_dentry->d_name)) { + err = update_dent_inode(old_inode, new_inode, + &new_dentry->d_name); + if (err) { release_orphan_inode(sbi); goto put_out_dir; } -- 2.7.0