public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Kiwoong Kim" <kwmad.kim@samsung.com>
To: "'Adrian Hunter'" <adrian.hunter@intel.com>,
	<linux-scsi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<alim.akhtar@samsung.com>, <avri.altman@wdc.com>,
	<jejb@linux.ibm.com>, <martin.petersen@oracle.com>,
	<beanhuo@micron.com>, <cang@codeaurora.org>, <sc.suh@samsung.com>,
	<hy50.seo@samsung.com>, <sh425.lee@samsung.com>,
	<bhoon95.kim@samsung.com>, <vkumar.1997@samsung.com>
Subject: RE: [RESEND PATCH v1] scsi: ufs: exclude UECxx from SFR dump list
Date: Tue, 8 Mar 2022 17:10:32 +0900	[thread overview]
Message-ID: <017301d832c3$fb59d690$f20d83b0$@samsung.com> (raw)
In-Reply-To: <52bbbd92-17d4-a5ea-150e-28cf56bb0a67@intel.com>

> > -	for (pos = 0; pos < len; pos += 4)
> > +	for (pos = 0; pos < len; pos += 4) {
> > +		if (pos >= REG_UIC_ERROR_CODE_PHY_ADAPTER_LAYER	&&
> > +		    pos <= REG_UIC_ERROR_CODE_DME)
> 
> Doesn't that need to be 'pos + offset' not just 'pos'
> 

For only ufshcd.c, offset is always zero, so 'offset' doesn't need to be referred to.
But now I think the function is currently public to external modules.

Okay, let me modify this.

Thanks.
Kiwoong Kim


      reply	other threads:[~2022-03-08  8:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220307024436epcas2p1cb5b07d5149b37610819fa3d70af59ea@epcas2p1.samsung.com>
2022-03-07  2:43 ` [RESEND PATCH v1] scsi: ufs: exclude UECxx from SFR dump list Kiwoong Kim
2022-03-08  5:15   ` Adrian Hunter
2022-03-08  8:10     ` Kiwoong Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='017301d832c3$fb59d690$f20d83b0$@samsung.com' \
    --to=kwmad.kim@samsung.com \
    --cc=adrian.hunter@intel.com \
    --cc=alim.akhtar@samsung.com \
    --cc=avri.altman@wdc.com \
    --cc=beanhuo@micron.com \
    --cc=bhoon95.kim@samsung.com \
    --cc=cang@codeaurora.org \
    --cc=hy50.seo@samsung.com \
    --cc=jejb@linux.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=sc.suh@samsung.com \
    --cc=sh425.lee@samsung.com \
    --cc=vkumar.1997@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox