From: Ahmed Abdelsalam <ahabdels@gmail.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: davem@davemloft.net, kuznet@ms2.inr.ac.ru,
yoshfuji@linux-ipv6.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, andrea.mayer@uniroma2.it
Subject: Re: [net-next v2] seg6: using DSCP of inner IPv4 packets
Date: Tue, 4 Aug 2020 09:42:07 +0200 [thread overview]
Message-ID: <01738166-f784-09f3-2286-150442ffa237@gmail.com> (raw)
In-Reply-To: <20200803124817.5068e06d@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
The problem was the declaration of tos.
Fixed and new patch is sent.
On 03/08/2020 21:48, Jakub Kicinski wrote:
> On Mon, 3 Aug 2020 18:14:17 +0000 Ahmed Abdelsalam wrote:
>> This patch allows copying the DSCP from inner IPv4 header to the
>> outer IPv6 header, when doing SRv6 Encapsulation.
>>
>> This allows forwarding packet across the SRv6 fabric based on their
>> original traffic class.
>>
>> Signed-off-by: Ahmed Abdelsalam <ahabdels@gmail.com>
>
> Please make sure it builds cleanly with W=1 C=1:
>
> net/ipv6/seg6_iptunnel.c:131:21: warning: incorrect type in assignment (different base types)
> net/ipv6/seg6_iptunnel.c:131:21: expected restricted __be32 [usertype] tos
> net/ipv6/seg6_iptunnel.c:131:21: got unsigned char
> net/ipv6/seg6_iptunnel.c:133:21: warning: incorrect type in assignment (different base types)
> net/ipv6/seg6_iptunnel.c:133:21: expected restricted __be32 [usertype] tos
> net/ipv6/seg6_iptunnel.c:133:21: got unsigned char [usertype] tos
> net/ipv6/seg6_iptunnel.c:144:27: warning: incorrect type in argument 2 (different base types)
> net/ipv6/seg6_iptunnel.c:144:27: expected unsigned int tclass
> net/ipv6/seg6_iptunnel.c:144:27: got restricted __be32 [usertype] tos
>
prev parent reply other threads:[~2020-08-04 7:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-03 18:14 [net-next v2] seg6: using DSCP of inner IPv4 packets Ahmed Abdelsalam
2020-08-03 19:48 ` Jakub Kicinski
2020-08-04 7:42 ` Ahmed Abdelsalam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01738166-f784-09f3-2286-150442ffa237@gmail.com \
--to=ahabdels@gmail.com \
--cc=andrea.mayer@uniroma2.it \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox