Re: [PATCH 1/2] kthread_create

Davide Libenzi
2004-03-29T15:42:16Z

On Sat, 3 Jan 2004, Rusty Russell wrote:

> Still do. It's *simple*, and I refuse to be ashamed of that.
>
> My words were harsh, but I completely disagree with you. I believe
> you are wrong. I would never have coded it the way you did. I read
> your code and I still think you are wrong, and find your code both
> bloated and ugly.

Bloated ? This is the diffstat of my "ashamed" patch over your bits :-)

include/linux/init_task.h | 3 +
include/linux/sched.h | 8 ++++
kernel/kthread.c | 78 ++++++++++++++++------------------------------
3 files changed, 39 insertions(+), 50 deletions(-)

> Now, on something we do agree: I dislike the global structure myself.
> By all means try changing the code to use a pipe between child and
> parent for the initfn result. But I've told you that I will not
> submit any solution which adds to a generic structure for a specific
> problem.
>
> I'm very, very sorry this has gotten a little heated: I generally
> enjoy our discussions. But I don't think I should have to say "no"
> four times.

It's ok Rusty, I enjoy the discussion in any case :-) Since I told you in
a private email that I was convinced myself about adding stuff inside the
struct, you could have avoided the "ashamed" thing. But it's fine, a
little bit of sarcasm is the salt of life.

- Davide