From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753172AbcEZHvx (ORCPT <rfc822;w@1wt.eu>);
	Thu, 26 May 2016 03:51:53 -0400
Received: from out4133-130.mail.aliyun.com ([42.120.133.130]:1888 "EHLO
	out4133-130.mail.aliyun.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1750791AbcEZHvw (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 26 May 2016 03:51:52 -0400
X-Greylist: delayed 318 seconds by postgrey-1.27 at vger.kernel.org; Thu, 26 May 2016 03:51:50 EDT
X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R381e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03303;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=3;SR=0;TI=SMTPD_----4r3nKVL_1464248774;
Reply-To: "Hillf Danton" <hillf.zj@alibaba-inc.com>
From: "Hillf Danton" <hillf.zj@alibaba-inc.com>
To: "'Jeff Chua'" <jeff.chua.linux@gmail.com>
Cc: "'Al Viro'" <viro@zeniv.linux.org.uk>,
        "linux-kernel" <linux-kernel@vger.kernel.org>
References: <017b01d1b721$d1686aa0$74393fe0$@alibaba-inc.com>
In-Reply-To: <017b01d1b721$d1686aa0$74393fe0$@alibaba-inc.com>
Subject: Re: can't boot with reiserfs on linux-4.6.0+
Date: Thu, 26 May 2016 15:46:14 +0800
Message-ID: <017c01d1b722$ae11fac0$0a35f040$@alibaba-inc.com>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQF7hB72R/A+DoQFMNtml6XPfcUSM6B3O2vQ
Content-Language: zh-cn
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> > See if this fixes your reproducer.
> >
> > diff --git a/fs/xattr.c b/fs/xattr.c
> > index b11945e..49b8eab 100644
> > --- a/fs/xattr.c
> > +++ b/fs/xattr.c
> > @@ -667,6 +667,9 @@ xattr_resolve_name(const struct xattr_handler **handlers, const char **name)
> >  {
> >         const struct xattr_handler *handler;
> >
> > +       if (!handlers)
> > +               return NULL;
> > +
> >         if (!*name)
> >                 return NULL;
> >
> 
> Tried, but doesn't work.
> 
See if this fixes your reproducer.

--- linux-4.6/fs/xattr.c	Mon May 16 06:43:13 2016
+++ b/fs/xattr.c	Thu May 26 15:36:14 2016
@@ -667,8 +667,8 @@ xattr_resolve_name(const struct xattr_ha
 {
 	const struct xattr_handler *handler;
 
-	if (!*name)
-		return NULL;
+	if (!handlers || !*name)
+		return ERR_PTR(-EINVAL);
 
 	for_each_xattr_handler(handlers, handler) {
 		const char *n;
--