public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pavel Fedin <p.fedin@samsung.com>
To: "'Pankaj Dubey'" <pankaj.dubey@samsung.com>,
	linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Cc: thomas.ab@samsung.com, k.kozlowski@samsung.com, kgene@kernel.org,
	heiko@sntech.de
Subject: RE: [PATCH v2 0/7] Add support for Exynos SROM Controller driver
Date: Mon, 05 Oct 2015 14:36:32 +0300	[thread overview]
Message-ID: <018501d0ff62$1650b410$42f21c30$@samsung.com> (raw)
In-Reply-To: <1440403348-8974-1-git-send-email-pankaj.dubey@samsung.com>

 Hello!

> This patch set adds support for Exynos SROM controller DT based driver.
> Currently SROM register sets are used only during S2R, so driver
> basically added for taking care of S2R. It will help us in removing
> static mapping from exynos.c and other extra code handline during S2R.

 Very good news, but, your driver seems not to do anything except suspend/resume. But how do i add
some device plugged into it? In order to be operational, its outputs have to be configured. But how
do i do it with your driver? For example, on SMDK boards SROM controller is used to connect SMSC9111
etherner chip.
 Currently i use hardcoded initialization based on of_machine_is_compatible(), but i believe this
would be considered a hack and such a thing cannot be pushed upstream. I guess i have to put all
needed configuration into device tree somehow. But how? Are there any recommentations?

Kind regards,
Pavel Fedin
Expert Engineer
Samsung Electronics Research center Russia



  parent reply	other threads:[~2015-10-05 11:36 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-24  8:02 [PATCH v2 0/7] Add support for Exynos SROM Controller driver Pankaj Dubey
2015-08-24  8:02 ` [PATCH v2 1/7] ARM: EXYNOS: remove unused static mapping of CMU for exynos5 Pankaj Dubey
2015-08-25  0:55   ` Krzysztof Kozlowski
2015-08-24  8:02 ` [PATCH v2 2/7] ARM: EXYNOS: code cleanup in map.h Pankaj Dubey
2015-08-25  0:56   ` Krzysztof Kozlowski
2015-08-24  8:02 ` [PATCH v2 3/7] drivers: soc: add support for exynos SROM driver Pankaj Dubey
2015-08-25  1:26   ` Krzysztof Kozlowski
2015-08-24  8:02 ` [PATCH v2 4/7] ARM: EXYNOS: Remove SROM related register settings from mach-exynos Pankaj Dubey
2015-08-25  1:53   ` Krzysztof Kozlowski
2015-08-24  8:02 ` [PATCH v2 5/7] ARM: dts: add SROM device node for exynos4 Pankaj Dubey
2015-08-25  1:57   ` Krzysztof Kozlowski
2015-08-24  8:02 ` [PATCH v2 6/7] ARM: dts: add SROM device node for exynos5 Pankaj Dubey
2015-08-25  2:03   ` Krzysztof Kozlowski
2015-08-24  8:02 ` [PATCH v2 7/7] Documentation: dt-bindings: add exynos-srom binding information Pankaj Dubey
2015-08-25  2:03   ` Krzysztof Kozlowski
2015-08-25  2:18 ` [PATCH v2 0/7] Add support for Exynos SROM Controller driver Krzysztof Kozlowski
2015-10-13 13:25   ` Pankaj Dubey
2015-09-16 23:19 ` Kukjin Kim
2015-10-05 11:36 ` Pavel Fedin [this message]
2015-10-05 12:48   ` Krzysztof Kozlowski
2015-10-05 13:18     ` Pavel Fedin
2015-10-06  0:23       ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='018501d0ff62$1650b410$42f21c30$@samsung.com' \
    --to=p.fedin@samsung.com \
    --cc=heiko@sntech.de \
    --cc=k.kozlowski@samsung.com \
    --cc=kgene@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=pankaj.dubey@samsung.com \
    --cc=thomas.ab@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox