From: "Doug Smythies" <dsmythies@telus.net>
To: "'Vlastimil Babka'" <vbabka@suse.cz>,
"'Andrew Morton'" <akpm@linux-foundation.org>
Cc: "'Michael Matz'" <matz@suse.de>,
"'Gabriel Krisman Bertazi'" <gabriel@krisman.be>,
"'Matthias Bodenbinder'" <matthias@bodenbinder.de>,
"'Lorenzo Stoakes'" <lorenzo.stoakes@oracle.com>,
"'Yang Shi'" <yang@os.amperecomputing.com>,
"Doug Smythies" <dsmythies@telus.net>,
<linux-kernel@vger.kernel.org>, <linux-mm@vger.kernel.org>
Subject: REGRESSION BISECTED mm, mmap: limit THP alignment of anonymous mappings to PMD-aligned sizes
Date: Mon, 3 Feb 2025 16:56:12 -0800 [thread overview]
Message-ID: <019401db769f$961e7e20$c25b7a60$@telus.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 1579 bytes --]
Hello,
Note: The CC list is a guess, and I am not on the two vger.kernel.org lists.
After observing a 30% reduction in the ebizzy benchmark performance, I bisected the kernel and got:
doug@s19:~/kernel/linux$ git bisect bad
d4148aeab412432bf928f311eca8a2ba52bb05df is the first bad commit
commit d4148aeab412432bf928f311eca8a2ba52bb05df
Author: Vlastimil Babka <vbabka@suse.cz>
Date: Thu Oct 24 17:12:29 2024 +0200
mm, mmap: limit THP alignment of anonymous mappings to PMD-aligned sizes
As a double check I reverted the commit, on top of kernel 6.14-rc1.
I had to manually revert it, due to other changes since then.
The previous performance of the benchmark was restored.
I actually use the sleeping-ebizzy benchmark [1].
I use it for idle governor testing because it has yielded interesting results in the past.
And sweep over a range of sleep times. Example graphs attached.
Legend (regression average is over interval range from 400 to 3600 uSec):
teo611: kernel 6.11, teo idle governor. Reference.
teo614: kernel 6.14-rc1, teo idle governor. Regression 25.7%
teo612: kernel 6.12, teo idle governor. Regression 24.4%
teo613: kernel 6.13, teo idle governor. Regression 25.1%
teo614-revert: kernel 6.14-rc1, with this patch reverted, teo idle governor. No regression, 1.4%
menu: kernel 6.14-rc1, menu idle governor. Regression 26.4%
Example command:
./ebizzy -m -S 20 -t 128 -a 1 -i 400
My processor: Intel(R) Core(TM) i5-10600K CPU @ 4.10GHz
Distro: Ubuntu 24.04, server, no desktop GUI.
[1] https://github.com/pratiksampat/sleeping-ebizzy
Doug Smythies
[-- Attachment #2: interval-sweep.png --]
[-- Type: image/png, Size: 32339 bytes --]
[-- Attachment #3: relative-performance.png --]
[-- Type: image/png, Size: 42078 bytes --]
next reply other threads:[~2025-02-04 0:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 0:56 Doug Smythies [this message]
2025-02-04 11:04 ` REGRESSION BISECTED mm, mmap: limit THP alignment of anonymous mappings to PMD-aligned sizes Vlastimil Babka
2025-02-05 4:35 ` Doug Smythies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='019401db769f$961e7e20$c25b7a60$@telus.net' \
--to=dsmythies@telus.net \
--cc=akpm@linux-foundation.org \
--cc=gabriel@krisman.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=matthias@bodenbinder.de \
--cc=matz@suse.de \
--cc=vbabka@suse.cz \
--cc=yang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox