From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qk1-f169.google.com (mail-qk1-f169.google.com [209.85.222.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E620243C7A5 for ; Fri, 24 Jul 2026 21:10:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784927439; cv=none; b=mOVdihnKWpvBkEVYPdDIwa8hb+4zC2LG+suzF1JcUOr4s6dScj3/lCXxL2sa6H+twYbr8ButV3IebyW2a73eLvES1z2SG9Kb9GWbmNpLV1ksJ/jUIAsa1Qkncjh7Zg2o0V8Xj7qaaTahMZZm1ZR+8Op9m36h9Cq/twUYBGniMtM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784927439; c=relaxed/simple; bh=uJykGS3QzQ4tvxZjLWHg5877iVJ4SfE3tavrwKMgWvY=; h=Date:Message-ID:MIME-Version:Content-Type:From:To:Cc:Subject: References:In-Reply-To; b=teomar2jrlO/OKQjRqJv+2hz5jUVrPO2SWEkgBJ86hDCia+IUWK7CpGi1d54Q/1T/GDi8+38YznIu+TEnHa3i3JdK7M0Sz2oKSdQagLeF7JQoah8Ha8DFLy1ytZKUOOCHHtgV78mVzZ+LNvBqwoRodBeWwqMx1gURU7LSDZkuJ4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com; spf=pass smtp.mailfrom=paul-moore.com; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b=XY9F4k4v; arc=none smtp.client-ip=209.85.222.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=paul-moore.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore.com header.i=@paul-moore.com header.b="XY9F4k4v" Received: by mail-qk1-f169.google.com with SMTP id af79cd13be357-92e5d50b0dbso65797885a.1 for ; Fri, 24 Jul 2026 14:10:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore.com; s=google; t=1784927437; x=1785532237; darn=vger.kernel.org; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :content-type:mime-version:message-id:date:from:to:cc:subject:date :message-id:reply-to:content-type; bh=yHq87L9vS3HaE9jFDV8bI4q/vxtGKRIuk5rLrUpJx2M=; b=XY9F4k4v1mK16fiOg3tFiRVBKhDyczLVSXM5P8e7GhrLs2Ym3ZYtZIlQlUwVbFOex2 w/rD4ksL4FdN45QllnvZlpzNw064gQcbIFs8RWCRI+p+W5ofwIde95TStccIOJktC7Bj LR1YO4Y8H7Gv8+zQA8mwp5joYwmGupwxOQqdJ8p5GvP1nOUTo1Zn2s75MNsCeUdxUUPo t/Y4+Iw1uuU5lJ/lAKV9brLaNi9TFo9v9x6ryXzciiCvscD5uCMeGU93MpDz1vYhqaF4 KyNhLJIb74wRu+vCXyT8ro6BICX7RVMT32l32nSYtPWdxwQB8IfFYX0ufF62mYWhiAlC iYMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784927437; x=1785532237; h=in-reply-to:references:subject:cc:to:from:content-transfer-encoding :content-type:mime-version:message-id:date:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=yHq87L9vS3HaE9jFDV8bI4q/vxtGKRIuk5rLrUpJx2M=; b=JbRKjF8PG4SO4SGbRsr1DTchYk4ybd4sll5IplUHKmXe1P5MeY6oiKqOBnxnzDFfh9 rdE7ZvPVX/MjwmDrbjfJtVVk+KGi5sZ0K11No5f+hLU9Pns6a+e18kdZY3iFYzlx7Yvv BCLK/olRxiktBOB3y0FSDjoBjplDa15FiQmtB0fOKMr5yNxk3KKDx8OdOtXdn3SMRQ0o NwdKA7r/GqG1Xwpx6qjsvZ36W315Qr0MBrYNmsCGWY5nz8fJtjuAj6vRKEHlklaAMiyB 8EU1VtvLtyoHWUgMoje8OZJ1MlNuhtmNpKH4o6x8RvwRVcsqwTpmeuHelc6fnean9F+5 TCFg== X-Forwarded-Encrypted: i=1; AHgh+Rqx30zDTS1rB3kL703UVr3Cc3j66TyQbX2OEzDtTuwvkNdncI6n7nmel8NYKVgqznj/Dmqf7KRY/gt855Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwGbmL0I2XOO0UBpr18mmkoGGD7q7/JoPuBV8kBQR2i/07erK3i q75fOaT3/bhe+NFLOWbotgXQS48fiQNQvHvaopssjKzuIRfuE/9mZk3JKD/VFEUImA== X-Gm-Gg: AR+sD11/c9CKyfSeXhhyg7XTLW5JOe2A6LbPXP6hpRxuCRXqLsgXSo8OfTrfONGLWVW xDn1LteMoYR67OQxlZSq/35Jy9/Fs13sfo7AKNxu7ivuF1s+od7wgDQapnqbeL/tYFS5NUhwRyE HopNUh0u2jhDenkNfyzyTu8GSstQ38FZhxbfnL3LgM0goZFgUSoyh6NNvFGy8nwXQ+vZgtwPMjT oJpWPAlms7Xt1B/OSlRDgaz3qWAn+ncyFE1UQHRlNRdtcqHRAqum93wnNXr07GKqvfcw4Xlx0U0 yfUWEHTOuCuX20p+8gAoNcXLzhbnXZTKdNk2+tQsacBdEgOnxm+X3Wie/KX4Xbh1nFWSFhTrLEd jzpeXKr3TneoPjCmfNPNzCFMwgcCUpvujYErf0jHITLW3i9AQgxIBKn6zMlESudi/eHsSJyQy3Y WZfXCj2XOB12CqdQxpofr/z++VH1zzeCQ7mKz46sbVKrNwnw5K9E09Ly4/6w== X-Received: by 2002:a05:620a:294e:b0:92e:c28c:9dff with SMTP id af79cd13be357-93103806f5fmr933223085a.6.1784927436759; Fri, 24 Jul 2026 14:10:36 -0700 (PDT) Received: from localhost (pool-71-126-255-178.bstnma.fios.verizon.net. [71.126.255.178]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-907e86d499dsm6519536d6.42.2026.07.24.14.10.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 24 Jul 2026 14:10:35 -0700 (PDT) Date: Fri, 24 Jul 2026 17:10:34 -0400 Message-ID: <0194430e27db3bcdffcf95b5dbf4891c@paul-moore.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Mailer: pstg-pwork:20260724_1628/pstg-lib:20260724_1535/pstg-pwork:20260724_1628 From: Paul Moore To: Jori Koolstra , Alexander Viro , Christian Brauner , Eric Paris Cc: Jan Kara , NeilBrown , linux-fsdevel@vger.kernel.org, audit@vger.kernel.org, linux-kernel@vger.kernel.org, Jori Koolstra Subject: Re: [PATCH 1/3] vfs: move create error && negative dentry case in lookup_open() up References: <20260710164233.827744-2-jkoolstra@xs4all.nl> In-Reply-To: <20260710164233.827744-2-jkoolstra@xs4all.nl> On Jul 10, 2026 Jori Koolstra wrote: > > O_CREAT is stripped when create_error is set in lookup_open(), so when > lookup does not return an inode, the case > > if (!dentry->d_inode && (open_flag & O_CREAT)) > > is always skipped. We can get rid of this cognitive step by handling the > error case first. > > Reviewed-by: NeilBrown > Signed-off-by: Jori Koolstra > --- > fs/namei.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) Reviewed-by: Paul Moore -- paul-moore.com