From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7851E2E03E4 for ; Wed, 7 Jan 2026 10:17:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767781077; cv=none; b=GXtZ89bL/+RGNfyeR8ljch3v4j0k8hfm4VI0/AiZrvd1jfiVrq5WgPMU++Rd7xFz2xbDWTk7EgaeFYDOOMp+heTr23YLpelwQuOHKCQW5UAbfOb++f9+WYdFSFMmA3WPt5/y0paHY0bMKXes5Qd9hybL7wrgBr9dSN46pAvKCEg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1767781077; c=relaxed/simple; bh=sZ3mYpTbv/XotPCF4CdZdQgefByrsCZvWPwwcFuFdu8=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=BlNYTq4/NN/0X6IfFG2JPMoZSq3Pt8ZPNWAUZw1UdWpcgbQc8t1KNBCg65Mn/Q1R2pJz8XFY9zgyX82uk5Fejp1y8Ns3Ilo8gOQgbu1bbZtzY+pNqR2kOQeOw3Seo/ZU46MqECRPhho7xLzpHUFNytsNdhMbCF+q2BCTIbz0d/g= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X1+qLOGb; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X1+qLOGb" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-430f2ee2f00so951748f8f.3 for ; Wed, 07 Jan 2026 02:17:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1767781074; x=1768385874; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=zz5VqpciYzlzrDKhkNf3p0wOlTe+spDWVku/imh0wW8=; b=X1+qLOGbt8H+g5qDNZHBIy5tvYG6wB4JoYWcV87piCyg0xaFyFq5Cjp9HmMOzAcxr9 Vamw4onaXp0qIxWm65AHgC2wbfi9h+HRGuBZ4kmnTcwf4CF6ydHJ1Xsysd8zX34hxO4w h5YFR6c/qoZEfwq55dHv4JM4GnztZIPPt8aszg4V1BmxsNOKVa+beYRDylNWv04pjTwJ vRYxg/aBVaZnNfMkXqteBL0GzinOJuch267whNRTL3Da9EhjQdc+bUmLCvzQlnBD6x7D 38bspZlPuXqGcY0RDICLUfYLnztecMnbeoWPODWiyv3qb5vYN7RAX3e+kExTbYfQL9t9 Ub2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1767781074; x=1768385874; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zz5VqpciYzlzrDKhkNf3p0wOlTe+spDWVku/imh0wW8=; b=ohFL7gb8I06gW6kzhG5mu0GR0c4gGMbQ+1Ug5HZg+NWP+s5mRE4ThwdKWg87SXmw9D jdXIq1iu+U1hfHlgqbFhV4qPqKCHabmhh/Rg7QawlgckLlT5AF0Q4QcykvTqOVilAU+a 707+/XhBvjd/XgeU22EsHUC/uxWQ+M5yOoaSUEO6D11X0N6mSkfb1f1HDK5+MhGQqcqi hePomud1bIsSKsisD8lOTJw/bUtlNHHj3PBY/TZwKsufblnDbSxvqvtWhnQq6PrlRhc6 kegExF+bOzrVuhygUilizDJOr0bjQ+kYQKYMSCE/H/xYc6vPGhc2YHsnUL2O51HFofTv MtQA== X-Forwarded-Encrypted: i=1; AJvYcCWomSJWQRRAiv7nidkigQ1HsWw2VNC8GWDh37d+IOO9YHh5YBGWUceVrZin8fetp9oZikHdYWuXBFv2ipw=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0vhI3DiZhBHdBs332LwghPeh6JRr5K9+868cf8o9twkw0yGqi BbCsAGKjMUmxgyjGn8KLgSfq9hU+H+rgxeQe6i7XM5hXP7pER/C8xug4 X-Gm-Gg: AY/fxX5GUN+f8Ppkbo4aqpoThkoVJRX05HTP8BfO5ciGBzgAu1GWJuW9g7p4erZj54s osI6aonJFffPVuXxfyk9m/YuCMOvMvkfyKnlrNSZGxPnwieVRlwSoKHdrfJ8AGHbWjR+TIY/UrI /jLqSwuoWhohj8JhYCuFork+AQ9Z0+TZ4rV93G+ERKXkIto5CBTERTmbSbFKa1kFVDqDc0ozbx4 US8VuqucJ0/1ZICJvJclHHrsONmtLYuKcCfelMZQj+B2OT/RmaqDBrLfVwhXJCAAwqDziAlNZVb FVk7Bz6HT8n2Ic02t6M1geT9UjKvbQoGwwpcGH6bP0Nne3/cePCcPMw+e0fWA6uCKnZNg+F6wqD 33tVAzTQVtf45o+OC4Bth+3w+OyiCBgJ+4BxclZAkPeaEHNK0idsb0bW/H/0q9IWiM6mOOy4aaH 3IXs2XCJeCAaf4DM7rNn4= X-Google-Smtp-Source: AGHT+IGVy0IzKXT0arvwyJMRyYIHdNRpHdjTMklcKCCT8hfx7RIZD2RcwFg53tOX3u+ah11y3aFn3w== X-Received: by 2002:a05:6000:40dc:b0:432:5bf9:cf2e with SMTP id ffacd0b85a97d-432c377298amr2547801f8f.13.1767781073405; Wed, 07 Jan 2026 02:17:53 -0800 (PST) Received: from [192.168.1.187] ([161.230.67.253]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-432bd0e6784sm9281054f8f.19.2026.01.07.02.17.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 07 Jan 2026 02:17:53 -0800 (PST) Message-ID: <019bcd38dadb138fda4cf8b113c13b77a4581168.camel@gmail.com> Subject: Re: [PATCH v2 1/2] net: phy: adin: enable configuration of the LP Termination Register From: Nuno =?ISO-8859-1?Q?S=E1?= To: Andrew Lunn , Osose Itua Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, michael.hennerich@analog.com, jerome.oufella@savoirfairelinux.com Date: Wed, 07 Jan 2026 10:18:35 +0000 In-Reply-To: References: <20251222222210.3651577-1-osose.itua@savoirfairelinux.com> <20251222222210.3651577-2-osose.itua@savoirfairelinux.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2025-12-23 at 10:36 +0100, Andrew Lunn wrote: > > +static int adin_config_zptm100(struct phy_device *phydev) > > +{ > > + struct device *dev =3D &phydev->mdio.dev; > > + int reg; > > + int rc; > > + > > + if (!(device_property_read_bool(dev, "adi,low-cmode-impedance"))) > > + return 0; > > + > > + /* set to 0 to configure for lowest common-mode impedance */ > > + rc =3D phy_write_mmd(phydev, MDIO_MMD_VEND1, ADIN1300_B_100_ZPTM_DIMR= X, 0x0); > > + if (rc < 0) > > + return rc; > > + > > + reg =3D phy_read_mmd(phydev, MDIO_MMD_VEND1, ADIN1300_B_100_ZPTM_DIMR= X); > > + if (reg < 0) > > + return reg; > > + > > + if (!(reg & ADIN1300_B_100_ZPTM_EN_DIMRX)) { > > + phydev_err(phydev, "Failed to set lowest common-mode impedance.\n"); > > + return -EINVAL; > > + } >=20 > Under what condition do you think this could happen? Do you think > there are variants of the hardware which do not have this register? >=20 > Andrew I think he's just reading back the register to make sure the value was real= ly updated... If we were going to that for every write our lives would be miserable :). I looked at both adin1200 and adin1300 and they support this in the same wa= y so the above should just be: return phy_write_mmd()... - Nuno S=C3=A1