* [PATCH] scsi: ufs: exynos: constify driver data @ 2022-06-13 10:14 ` Krzysztof Kozlowski 2022-06-13 10:54 ` Chanho Park ` (2 more replies) 0 siblings, 3 replies; 4+ messages in thread From: Krzysztof Kozlowski @ 2022-06-13 10:14 UTC (permalink / raw) To: James E.J. Bottomley, Martin K. Petersen, Krzysztof Kozlowski, Alim Akhtar, linux-scsi, linux-arm-kernel, linux-samsung-soc, linux-kernel Constify the drv data because it should not be modified (used by multiple devices). Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- drivers/ufs/host/ufs-exynos.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/ufs/host/ufs-exynos.c b/drivers/ufs/host/ufs-exynos.c index a81d8cbd542f..9fef706d896e 100644 --- a/drivers/ufs/host/ufs-exynos.c +++ b/drivers/ufs/host/ufs-exynos.c @@ -157,7 +157,6 @@ enum { #define CNTR_DIV_VAL 40 -static struct exynos_ufs_drv_data exynos_ufs_drvs; static void exynos_ufs_auto_ctrl_hcc(struct exynos_ufs *ufs, bool en); static void exynos_ufs_ctrl_clkstop(struct exynos_ufs *ufs, bool en); @@ -1473,7 +1472,7 @@ static int exynosauto_ufs_vh_init(struct ufs_hba *hba) return 0; } -static struct ufs_hba_variant_ops ufs_hba_exynos_ops = { +static const struct ufs_hba_variant_ops ufs_hba_exynos_ops = { .name = "exynos_ufs", .init = exynos_ufs_init, .hce_enable_notify = exynos_ufs_hce_enable_notify, @@ -1545,7 +1544,7 @@ static struct exynos_ufs_uic_attr exynos7_uic_attr = { .pa_dbg_option_suite = 0x30103, }; -static struct exynos_ufs_drv_data exynosauto_ufs_drvs = { +static const struct exynos_ufs_drv_data exynosauto_ufs_drvs = { .uic_attr = &exynos7_uic_attr, .quirks = UFSHCD_QUIRK_PRDT_BYTE_GRAN | UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR | @@ -1561,7 +1560,7 @@ static struct exynos_ufs_drv_data exynosauto_ufs_drvs = { .post_pwr_change = exynosauto_ufs_post_pwr_change, }; -static struct exynos_ufs_drv_data exynosauto_ufs_vh_drvs = { +static const struct exynos_ufs_drv_data exynosauto_ufs_vh_drvs = { .vops = &ufs_hba_exynosauto_vh_ops, .quirks = UFSHCD_QUIRK_PRDT_BYTE_GRAN | UFSHCI_QUIRK_SKIP_RESET_INTR_AGGR | @@ -1573,7 +1572,7 @@ static struct exynos_ufs_drv_data exynosauto_ufs_vh_drvs = { .opts = EXYNOS_UFS_OPT_BROKEN_RX_SEL_IDX, }; -static struct exynos_ufs_drv_data exynos_ufs_drvs = { +static const struct exynos_ufs_drv_data exynos_ufs_drvs = { .uic_attr = &exynos7_uic_attr, .quirks = UFSHCD_QUIRK_PRDT_BYTE_GRAN | UFSHCI_QUIRK_BROKEN_REQ_LIST_CLR | -- 2.34.1 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] scsi: ufs: exynos: constify driver data 2022-06-13 10:14 ` [PATCH] scsi: ufs: exynos: constify driver data Krzysztof Kozlowski @ 2022-06-13 10:54 ` Chanho Park 2022-06-14 2:09 ` Martin K. Petersen 2022-06-17 2:21 ` Martin K. Petersen 2 siblings, 0 replies; 4+ messages in thread From: Chanho Park @ 2022-06-13 10:54 UTC (permalink / raw) To: 'Krzysztof Kozlowski', 'James E.J. Bottomley', 'Martin K. Petersen', 'Alim Akhtar', linux-scsi, linux-arm-kernel, linux-samsung-soc, linux-kernel > Subject: [PATCH] scsi: ufs: exynos: constify driver data > > Constify the drv data because it should not be modified (used by multiple > devices). > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Reviewed-by: Chanho Park <chanho61.park@samsung.com> Best Regards, Chanho Park ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: exynos: constify driver data 2022-06-13 10:14 ` [PATCH] scsi: ufs: exynos: constify driver data Krzysztof Kozlowski 2022-06-13 10:54 ` Chanho Park @ 2022-06-14 2:09 ` Martin K. Petersen 2022-06-17 2:21 ` Martin K. Petersen 2 siblings, 0 replies; 4+ messages in thread From: Martin K. Petersen @ 2022-06-14 2:09 UTC (permalink / raw) To: Krzysztof Kozlowski Cc: James E.J. Bottomley, Martin K. Petersen, Alim Akhtar, linux-scsi, linux-arm-kernel, linux-samsung-soc, linux-kernel Krzysztof, > Constify the drv data because it should not be modified (used by > multiple devices). Applied to 5.20/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: ufs: exynos: constify driver data 2022-06-13 10:14 ` [PATCH] scsi: ufs: exynos: constify driver data Krzysztof Kozlowski 2022-06-13 10:54 ` Chanho Park 2022-06-14 2:09 ` Martin K. Petersen @ 2022-06-17 2:21 ` Martin K. Petersen 2 siblings, 0 replies; 4+ messages in thread From: Martin K. Petersen @ 2022-06-17 2:21 UTC (permalink / raw) To: linux-kernel, James E.J. Bottomley, linux-arm-kernel, Alim Akhtar, Krzysztof Kozlowski, linux-samsung-soc, linux-scsi Cc: Martin K . Petersen On Mon, 13 Jun 2022 12:14:29 +0200, Krzysztof Kozlowski wrote: > Constify the drv data because it should not be modified (used by > multiple devices). > > Applied to 5.20/scsi-queue, thanks! [1/1] scsi: ufs: exynos: constify driver data https://git.kernel.org/mkp/scsi/c/dcad25cb2500 -- Martin K. Petersen Oracle Linux Engineering ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-06-17 2:21 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <CGME20220613101459epcas2p3ebbea864e0fe67f083127696028b1d75@epcas2p3.samsung.com>
2022-06-13 10:14 ` [PATCH] scsi: ufs: exynos: constify driver data Krzysztof Kozlowski
2022-06-13 10:54 ` Chanho Park
2022-06-14 2:09 ` Martin K. Petersen
2022-06-17 2:21 ` Martin K. Petersen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox