public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Chanho Park" <chanho61.park@samsung.com>
To: "'Arnd Bergmann'" <arnd@arndb.de>,
	"'Youngmin Nam'" <youngmin.nam@samsung.com>
Cc: "'John Stultz'" <jstultz@google.com>,
	"'Thomas Gleixner'" <tglx@linutronix.de>,
	"'Stephen Boyd'" <sboyd@kernel.org>,
	"'Linux Kernel Mailing List'" <linux-kernel@vger.kernel.org>,
	<hajun.sung@samsung.com>, <hosung0.kim@samsung.com>,
	<d7271.choe@samsung.com>
Subject: RE: [PATCH] time: remove useless "const" keyword in ns_to_kernel_old_timeval() and ns_to_timespec64()
Date: Tue, 12 Jul 2022 16:49:46 +0900	[thread overview]
Message-ID: <01a201d895c3$f4955ba0$ddc012e0$@samsung.com> (raw)
In-Reply-To: <CAK8P3a0pCov7ZiNhG+by7PpxMdBbBpUa7TKNc9e0p-zXvqg-7g@mail.gmail.com>

> > As mentioned below,
> >
> https://lore.kernel.org/lkml/CAK8P3a3nknJgEDESGdJH91jMj6R_xydFqWASd8r5Bbes
> dvMBgA@mail.gmail.com/

I'm not sure why you drop my originality but please use my commit message and put this link between --- and include/linux/time32.h if you need additional comments.
https://lore.kernel.org/all/20220531064346.51677-1-chanho61.park@samsung.com/T/

Indeed you should put Fixes tag for stable tree.

Best Regards,
Chanho Park

> >
> > The "const" keyword is useless, so we drop it from the function
> definition and declaration.
> >
> > Change-Id: If35bba78aa7757476e22be42afc719c27fb0f527
> > Signed-off-by: Youngmin Nam <youngmin.nam@samsung.com>
> 
> The patch looks good, but the description can be improved:
> 
> - drop the useless Change-Id field
> - move the URL into a 'Link: field'
> - wrap the lines to fit into the normal width of an email (under 80
> characters,
>   ideally 70)
> - explain why the change helps, rather than just stating the keyword is
> useless.
>   In your description, it's not clear if one is better than the other, it
> sounds
>   like it should make no difference.
> 
> With that done:
> 
> Reviewed-by: Arnd Bergmann <arnd@arndb.de>


      reply	other threads:[~2022-07-12  7:50 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20220712071941epcas2p2faa87d8efe182e9c28a924ea3de15209@epcas2p2.samsung.com>
2022-07-12  7:47 ` [PATCH] time: remove useless "const" keyword in ns_to_kernel_old_timeval() and ns_to_timespec64() Youngmin Nam
2022-07-12  7:41   ` Arnd Bergmann
2022-07-12  7:49     ` Chanho Park [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='01a201d895c3$f4955ba0$ddc012e0$@samsung.com' \
    --to=chanho61.park@samsung.com \
    --cc=arnd@arndb.de \
    --cc=d7271.choe@samsung.com \
    --cc=hajun.sung@samsung.com \
    --cc=hosung0.kim@samsung.com \
    --cc=jstultz@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sboyd@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=youngmin.nam@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox