From: "Roger Willcocks" <roger@filmlight.ltd.uk>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: <linux-kernel@vger.kernel.org>, <nfs@lists.sourceforge.net>,
"Neil Brown" <neilb@suse.de>
Subject: Re: nfsd bug: create file with specific uid/gid
Date: Sat, 1 Dec 2007 11:36:18 -0000 [thread overview]
Message-ID: <01bf01c8340e$63e90060$6501a8c0@BODDINGTON> (raw)
In-Reply-To: 20071130220127.GJ24887@fieldses.org
J. Bruce Fields wrote:
> On Fri, Nov 30, 2007 at 05:06:03PM +0000, Roger Willcocks wrote:
>> nfsd/vfs.c:nfsd_create (the v2 version of create) says:
>>
>> "Set file attributes. Mode has already been set and
>> setting uid/gid works only for root"
>>
>> but it doesn't actually test for root-ness
...
> Assignments (especially with things like &=) inside of conditionals
> always make my head hurt for some reason. So maybe something like the
> below?
The patch looks fine to me, note that nfsd_create_v3 needs fixing too.
>
> Thanks for the bug report! (And, by the way, how did you run across
> this?)
>
I'm working on an NFSp-like server for our clustered file system and my data
file creates were not working as expected.
--
Roger
next prev parent reply other threads:[~2007-12-01 11:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-30 17:06 nfsd bug: create file with specific uid/gid Roger Willcocks
2007-11-30 22:01 ` J. Bruce Fields
2007-12-01 11:36 ` Roger Willcocks [this message]
2007-12-03 16:17 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01bf01c8340e$63e90060$6501a8c0@BODDINGTON' \
--to=roger@filmlight.ltd.uk \
--cc=bfields@fieldses.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox