From: "Padmanabhan Rajanbabu" <p.rajanbabu@samsung.com>
To: "'Krzysztof Kozlowski'" <krzysztof.kozlowski@linaro.org>,
"'Alim Akhtar'" <alim.akhtar@samsung.com>, <lgirdwood@gmail.com>,
<broonie@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <s.nawrocki@samsung.com>,
<perex@perex.cz>, <tiwai@suse.com>, <pankaj.dubey@samsung.com>,
<rcsekar@samsung.com>, <aswani.reddy@samsung.com>
Cc: <alsa-devel@alsa-project.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
<linux-samsung-soc@vger.kernel.org>
Subject: RE: [PATCH 6/6] arm64: dts: fsd: Add sound card node for Tesla FSD
Date: Tue, 8 Nov 2022 10:55:13 +0530 [thread overview]
Message-ID: <01bf01d8f332$7c15fdc0$7441f940$@samsung.com> (raw)
In-Reply-To: <89340edb-2451-e648-e2e6-94c8f2410084@linaro.org>
> -----Original Message-----
> From: Krzysztof Kozlowski [mailto:krzysztof.kozlowski@linaro.org]
> Sent: 21 October 2022 06:24 PM
> To: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com>; 'Alim Akhtar'
> <alim.akhtar@samsung.com>; lgirdwood@gmail.com; broonie@kernel.org;
> robh+dt@kernel.org; krzysztof.kozlowski+dt@linaro.org;
> s.nawrocki@samsung.com; perex@perex.cz; tiwai@suse.com;
> pankaj.dubey@samsung.com; rcsekar@samsung.com;
> aswani.reddy@samsung.com
> Cc: alsa-devel@alsa-project.org; devicetree@vger.kernel.org; linux-
> kernel@vger.kernel.org; linux-samsung-soc@vger.kernel.org
> Subject: Re: [PATCH 6/6] arm64: dts: fsd: Add sound card node for Tesla FSD
>
> On 21/10/2022 04:12, Padmanabhan Rajanbabu wrote:
> >
> >
> >> -----Original Message-----
> >> From: Alim Akhtar [mailto:alim.akhtar@samsung.com]
> >> Sent: 14 October 2022 06:59 PM
> >> To: 'Padmanabhan Rajanbabu' <p.rajanbabu@samsung.com>;
> >> lgirdwood@gmail.com; broonie@kernel.org; robh+dt@kernel.org;
> >> krzysztof.kozlowski+dt@linaro.org; s.nawrocki@samsung.com;
> >> perex@perex.cz; tiwai@suse.com; pankaj.dubey@samsung.com;
> >> rcsekar@samsung.com; aswani.reddy@samsung.com
> >> Cc: alsa-devel@alsa-project.org; devicetree@vger.kernel.org; linux-
> >> kernel@vger.kernel.org; linux-samsung-soc@vger.kernel.org
> >> Subject: RE: [PATCH 6/6] arm64: dts: fsd: Add sound card node for
> >> Tesla FSD
> >>
> >>
> >>
> >>> -----Original Message-----
> >>> From: Padmanabhan Rajanbabu [mailto:p.rajanbabu@samsung.com]
> >>> Sent: Friday, October 14, 2022 3:52 PM
> >>> To: lgirdwood@gmail.com; broonie@kernel.org; robh+dt@kernel.org;
> >>> krzysztof.kozlowski+dt@linaro.org; s.nawrocki@samsung.com;
> >>> perex@perex.cz; tiwai@suse.com; pankaj.dubey@samsung.com;
> >>> alim.akhtar@samsung.com; rcsekar@samsung.com;
> >> aswani.reddy@samsung.com
> >>> Cc: alsa-devel@alsa-project.org; devicetree@vger.kernel.org; linux-
> >>> kernel@vger.kernel.org; linux-samsung-soc@vger.kernel.org;
> >> Padmanabhan
> >>> Rajanbabu <p.rajanbabu@samsung.com>
> >>> Subject: [PATCH 6/6] arm64: dts: fsd: Add sound card node for Tesla
> >>> FSD
> >>>
> >>> Add device tree node support for sound card on Tesla FSD board
> >>>
> >>> Signed-off-by: Padmanabhan Rajanbabu <p.rajanbabu@samsung.com>
> >>> ---
> >>> arch/arm64/boot/dts/tesla/fsd-evb.dts | 49
> >>> +++++++++++++++++++++++++++
> >>> arch/arm64/boot/dts/tesla/fsd.dtsi | 3 ++
> >>> 2 files changed, 52 insertions(+)
> >>>
> >>> diff --git a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> >>> b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> >>> index c0a4509499ab..ecaa3c2e3045 100644
> >>> --- a/arch/arm64/boot/dts/tesla/fsd-evb.dts
> >>> +++ b/arch/arm64/boot/dts/tesla/fsd-evb.dts
> >>> @@ -49,3 +49,52 @@
> >>> &tdm_1 {
> >>> status = "okay";
> >>> };
> >>> +
> >>> +&sound {
> >>> + compatible = "tesla,fsd-sndcard";
> >>> + status = "okay";
> >>> + model = "fsd-i2s";
> >>> + widgets =
> >>> + "Speaker", "MAIN SPK",
> >>> + "Microphone", "MAIN MIC";
> >>> +
> >>> + primary-dai-link-0 {
> >>> + link-name = "fsd-primary-0";
> >>> + dai-format = "i2s";
> >>> + tesla,bitclock-master = <&tdm_0>;
> >>> + tesla,frame-master = <&tdm_0>;
> >>> + cpu {
> >>> + sound-dai = <&tdm_0 0>;
> >>> + };
> >>> + };
> >>> +
> >>> + secondary-dai-link-0 {
> >>> + link-name = "fsd-secondary-0";
> >>> + dai-format = "i2s";
> >>> + tesla,bitclock-master = <&tdm_0>;
> >>> + tesla,frame-master = <&tdm_0>;
> >>> + cpu {
> >>> + sound-dai = <&tdm_0 1>;
> >>> + };
> >>> + };
> >>> +
> >>> + primary-dai-link-1 {
> >>> + link-name = "fsd-primary-1";
> >>> + dai-format = "i2s";
> >>> + tesla,bitclock-master = <&tdm_1>;
> >>> + tesla,frame-master = <&tdm_1>;
> >>> + cpu {
> >>> + sound-dai = <&tdm_1 0>;
> >>> + };
> >>> + };
> >>> +
> >>> + secondary-dai-link-1 {
> >>> + link-name = "fsd-secondary-1";
> >>> + dai-format = "i2s";
> >>> + tesla,bitclock-master = <&tdm_1>;
> >>> + tesla,frame-master = <&tdm_1>;
> >>> + cpu {
> >>> + sound-dai = <&tdm_1 1>;
> >>> + };
> >>> + };
> >>> +};
> >>> diff --git a/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> b/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> index 5decad45a1b6..fc8931f830a7 100644
> >>> --- a/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> +++ b/arch/arm64/boot/dts/tesla/fsd.dtsi
> >>> @@ -847,6 +847,9 @@
> >>> status = "disabled";
> >>> };
> >>>
> >>> + sound: sound {
> >>> + };
> >>> +
> >> Why to have an empty node in dtsi?
> > This is required as every node we use in dts should have the same
> > declared in
>
> I see no reason why this is required.
>
> > dtsi. Sound nodes in most of the platform is only declared (dummy
> > node) in dtsi and defining only in dts. Thus we are following the same.
>
> Can you point me to Samsung platform doing this?
>
> Keep the code consistent with Exynos style.
Okay, will add the sound node in accordance with Exynos style
>
> Best regards,
> Krzysztof
prev parent reply other threads:[~2022-11-08 6:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20221014104843epcas5p47f6daaad2e67e0c9eedd68c2256c025b@epcas5p4.samsung.com>
2022-10-14 10:21 ` [PATCH 0/6] ASoC: samsung: fsd: audio support for FSD SoC Padmanabhan Rajanbabu
2022-10-14 10:21 ` [PATCH 1/6] ASoC: samsung: i2s: TDM Support for CPU DAI driver Padmanabhan Rajanbabu
2022-10-14 10:21 ` [PATCH 2/6] ASoC: samsung: i2s: configure PSR from sound card Padmanabhan Rajanbabu
2022-10-14 12:02 ` Mark Brown
2022-10-21 8:00 ` Padmanabhan Rajanbabu
2022-10-21 11:53 ` Mark Brown
2022-11-08 5:23 ` Padmanabhan Rajanbabu
2022-11-09 17:38 ` Mark Brown
2023-01-03 4:55 ` Padmanabhan Rajanbabu
2022-10-23 13:12 ` Krzysztof Kozlowski
2022-10-14 10:21 ` [PATCH 3/6] dt-bindings: sound: Add sound card bindings for Tesla FSD Padmanabhan Rajanbabu
2022-10-14 15:13 ` Rob Herring
2022-10-21 8:44 ` Padmanabhan Rajanbabu
2022-10-22 16:48 ` Krzysztof Kozlowski
2022-11-08 5:33 ` Padmanabhan Rajanbabu
2022-11-08 10:36 ` Krzysztof Kozlowski
2022-10-14 10:21 ` [PATCH 4/6] ASoC: samsung: fsd: Add FSD soundcard driver Padmanabhan Rajanbabu
2022-10-14 12:23 ` Mark Brown
2022-10-21 8:09 ` Padmanabhan Rajanbabu
2022-10-16 15:18 ` Krzysztof Kozlowski
2022-10-21 9:04 ` Padmanabhan Rajanbabu
2022-10-14 10:21 ` [PATCH 5/6] arm64: dts: fsd: Add I2S DAI node for Tesla FSD Padmanabhan Rajanbabu
2022-10-14 13:24 ` Alim Akhtar
2022-10-21 8:09 ` Padmanabhan Rajanbabu
2022-10-16 15:14 ` Krzysztof Kozlowski
2022-10-21 8:49 ` Padmanabhan Rajanbabu
2022-10-21 13:01 ` Krzysztof Kozlowski
2022-11-08 5:26 ` Padmanabhan Rajanbabu
2022-10-14 10:21 ` [PATCH 6/6] arm64: dts: fsd: Add sound card " Padmanabhan Rajanbabu
2022-10-14 13:29 ` Alim Akhtar
2022-10-21 8:12 ` Padmanabhan Rajanbabu
2022-10-21 12:53 ` Krzysztof Kozlowski
2022-11-08 5:25 ` Padmanabhan Rajanbabu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01bf01d8f332$7c15fdc0$7441f940$@samsung.com' \
--to=p.rajanbabu@samsung.com \
--cc=alim.akhtar@samsung.com \
--cc=alsa-devel@alsa-project.org \
--cc=aswani.reddy@samsung.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=perex@perex.cz \
--cc=rcsekar@samsung.com \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox