From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lj1-f182.google.com (mail-lj1-f182.google.com [209.85.208.182]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 70D961B394E for ; Fri, 20 Dec 2024 09:23:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.208.182 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734686618; cv=none; b=q+PDC7PhipLj63Odf3ujyqKaoStnzBwa/3o8TPVetu/FtMa333Qwu8J+iT7X0VB/8TPY3xkN6NrLimXGoQGqGPi5p8+D2/ZR6GxCA+D5QrNIYiHsyUfCtnYfZWLfai7rNZaruTCzDFsc6zVcVxYR+h3+00TgS2JPx9KuaqLIHJk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734686618; c=relaxed/simple; bh=KCDElS5z2fsldc+2ATrCN2JR/gBjmVszXfvWzsZAGcg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=YBMlL9RRMLss7MZ5Nk8D7lwMOC0Q53ICrpVLIATkk3M2VEhHJbL6s6z2I70zhDJygONnjrRDtkFOMI3fK7ZsKcVUQmto/8H9tjtqo/pwyy1aPN8UHZWP9lmS9DYcBdhOeBv/JKgYN7AH//dtJ8o8isYrmcRaG1dtvCdy1kHRHIU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com; spf=pass smtp.mailfrom=cogentembedded.com; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b=k4tcOQI2; arc=none smtp.client-ip=209.85.208.182 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=cogentembedded.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20230601.gappssmtp.com header.i=@cogentembedded-com.20230601.gappssmtp.com header.b="k4tcOQI2" Received: by mail-lj1-f182.google.com with SMTP id 38308e7fff4ca-3003c82c95cso13273661fa.3 for ; Fri, 20 Dec 2024 01:23:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20230601.gappssmtp.com; s=20230601; t=1734686614; x=1735291414; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/+TrNT5jtIAZL9awK5DM1/5/DLxJyjtDlozW1sMJY2Y=; b=k4tcOQI223Uo2PjJdOALHOE4qd/E5CIOLHru9d5Bm2BV8I7R07rH/8mLlureqvTrTk SzZjQisa12cEPn3Jdw7DEV3A0M3gIDGG2dsrHreCUNgAvLcU58SBW3eoJUlO7XGWurLk b20ut85yagajILvB55hoUGqCml9ZLU+sRBWbCvVUG3J9bm4cmrOF3ZYGQMNH5SZhDLUE n/pw17cI1jzd28673DqB1EOjZpD2AtQvmZiMt5xGv2DvzxLMfnacQeaZ4iYmlK9hhFpl udoA/8FCLR4qUoMXMFPJfemV0fUoVqU8TGlyTGpDlhBG/raF+SYbtGSIEEtnBCGOQrOi yDMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734686614; x=1735291414; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/+TrNT5jtIAZL9awK5DM1/5/DLxJyjtDlozW1sMJY2Y=; b=s3I5QWs0IGUHOe+Cff0ZX9Sk9L/a24rsPLgKHzN0Lg4kt1/+3dVNAKTuBNS1ol7DZp Yr2RB9pgPgnLdT5Kg4GqxLefVvX/x32c1MVGh6wAD1WwJe82of2j2YM78/USk+8fNkaM JjNJVrvf1bZ6I8vBUc0KsYQWiC3/OIKibNXJuKtIfPnBXuhO4vKiEA2HZNh5HEohpvtq uuSbepbjL1gpglNdBV668p086Sq7wnfO/krRRAZIQcMHwwGse0vtdueqDkXJg6D7j5s1 AHjqN013H7P+BZV82Q0Q6jVoSogMa2hCNvG7K0z0EUmbt1KY6dCPWoEjyeiklCePj5sM mARQ== X-Forwarded-Encrypted: i=1; AJvYcCUe1/bZGF5TtCaxA6w3T5WtD+9SrpNdPtOQh3PamTutnr4BcwZiFL2hPB/DhK3Y7ZuUbbD3lX7H+8XQXc0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzk0YKr2UdcnSNzew7eS4Ba44xN5cqyrCy/+iY7Y16LudQ6HbKT hgriMeuYHUqqFbyRURYwXABrXbzGgKDSaxklOdXTqafkuzIjKT5FIV62yqIGLKA= X-Gm-Gg: ASbGncsvaWNCSVa9VnB6fRjL3FJcLS0yS9m4jfcIddiCzo43ir4M/liGZnBMY34sKI/ ZIZblUZ+AQ0WBBlqAS4k6Xm76IFOXyYlYw82xdkdrYljlY0HneuLqErnbq/NAGu0fxixr0q6uLe i4ygxreBeZXBSaokRu0f+N4qoQbk279QFjatD7/62UcSyz0CSuwQzRYFVwuKRa8C6OlKAwuborK fx4UX/EG+nObWIFusTV5D0cH+KI4Q+FmGeKtV+DUa/hB0ctG/+tbCNKRZbFSTQf6Pvivn8KKQz7 X-Google-Smtp-Source: AGHT+IGfz2PHNF/FWn/hpRtN9wfgXh99+gz7PviQ4rLuDyLIigC69aw87cFOnBjDw/N8prGJPeb5aw== X-Received: by 2002:a2e:bc23:0:b0:300:31db:a770 with SMTP id 38308e7fff4ca-3046860d416mr7731831fa.26.1734686614551; Fri, 20 Dec 2024 01:23:34 -0800 (PST) Received: from [192.168.0.104] ([91.198.101.25]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-3045ad6cfe8sm4729851fa.6.2024.12.20.01.23.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 20 Dec 2024 01:23:34 -0800 (PST) Message-ID: <01c3755a-d57c-4da8-9505-551663a694c7@cogentembedded.com> Date: Fri, 20 Dec 2024 14:23:31 +0500 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next 1/2] net: renesas: rswitch: use per-port irq handlers To: Yoshihiro Shimoda , Geert Uytterhoeven Cc: Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Geert Uytterhoeven , "netdev@vger.kernel.org" , "linux-renesas-soc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Michael Dege , Christian Mardmoeller , Dennis Ostermann , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <20241220041659.2985492-1-nikita.yoush@cogentembedded.com> <20241220041659.2985492-2-nikita.yoush@cogentembedded.com> <7b009b7f-0406-4dc1-80b3-79927d6143f0@cogentembedded.com> Content-Language: en-US, ru-RU From: Nikita Yushchenko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit >>> Sorry, but I can't find where this property is documented? >> >> I will add this. > > Device tree properties should be a hardware description. However, > about the "irq-index", it seems a software configuration. So, even if we would > like to submit such a patch to add the property, it will be rejected. Hmm... Indeed it is a software configuration. I was not aware of such a rule. I believe there shall be plenty of situations when a per-hardware-node software configuration is desired. What method do other use, if not device tree? > Also, even if we can add a new device tree property, we should keep backward compatible. > However, this patch seems to break a backward compatibility. It does not. If this new property is not defined, then it will default to 0, which will result exactly into previous behavior. > Unfortunately, I don't have alternative solutions how to configurate per-port irq though... > # Maybe configfs?? Looks like overengineering... Perhaps can just hardcode irq-index N for port N for now. But then, flexibility will be lost. In more complex situations that I target in future, some of 8 GWCA interrupts will be given to virtual machines (and/or Xen domains) to serve virtual port frontends, and some will be needed for virtual port backends. So 8 will be not enough to have a per-consumer interrupt, and some configuration method is needed. Nikita