Re: [PATCH 2/5] dt-bindings: clock: add clock binding definitions for Exynos Auto v920

Krzysztof Kozlowski
2024-07-05T09:12:48Z

On 05/07/2024 11:08, sunyeal.hong wrote:
> Hello Krzysztof Kozlowski,
>
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: Friday, July 5, 2024 5:52 PM
>> To: sunyeal.hong <sunyeal.hong@samsung.com>; 'Sylwester Nawrocki'
>> <s.nawrocki@samsung.com>; 'Chanwoo Choi' <cw00.choi@samsung.com>; 'Alim
>> Akhtar' <alim.akhtar@samsung.com>; 'Michael Turquette'
>> <mturquette@baylibre.com>; 'Stephen Boyd' <sboyd@kernel.org>
>> Cc: linux-samsung-soc@vger.kernel.org; linux-clk@vger.kernel.org; linux-
>> kernel@vger.kernel.org
>> Subject: Re: [PATCH 2/5] dt-bindings: clock: add clock binding definitions
>> for Exynos Auto v920
>>
>> On 05/07/2024 10:03, sunyeal.hong wrote:
>>>
>>>>
>>>> Please use scripts/get_maintainers.pl to get a list of necessary
>>>> people and lists to CC. It might happen, that command when run on an
>>>> older kernel, gives you outdated entries. Therefore please be sure
>>>> you base your patches on recent Linux kernel.
>>>>
>>>> Tools like b4 or scripts/get_maintainer.pl provide you proper list of
>>>> people, so fix your workflow. Tools might also fail if you work on
>>>> some ancient tree (don't, instead use mainline) or work on fork of
>>>> kernel (don't, instead use mainline). Just use b4 and everything
>>>> should be fine, although remember about `b4 prep --auto-to-cc` if you
>>>> added new patches to the patchset.
>>>>
>>>> You missed at least devicetree list (maybe more), so this won't be
>>>> tested by automated tooling. Performing review on untested code might
>>>> be a waste of time.
>>>>
>>>> Please kindly resend and include all necessary To/Cc entries.
>>>>
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>> The mail list was created using get_maintainer.pl. If there is any
>> problem, please let me know.
>>>
>>> ./scripts/get_maintainer.pl -f drivers/clk/samsung/
>>
>> That's not how you run the command. You ALWAYS (unless you are Linus) run
>> it on the patches. ALWAYS. See submitting patches or numerous
>> presentations how to contribute upstream.
>>
>> Read my form letter accurately, e.g. switch to b4.
>>
>> Best regards,
>> Krzysztof
>
> Thank you for your quick and kind response.
> I checked the difference in the mail list through "./scripts/get_maintainer.pl *.patch" and will reflect this.
>
> Could you please answer additional questions I asked?
> "Is your request to combine PATCH 0 and 1 correct? If correct, I will update it as requested."
>
> The reason I'm asking this is that if you check checkpatch.pl, it says to classify patches as follows.
> "DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst"
> PATCH0: Documentation/devicetree/bindings/clock/samsung,exynosautov920-clock.yaml
> PATCH1: include/dt-bindings/clock/samsung,exynosautov920.h

Separate from the drivers, not from each other! This does not make sense
to keep them separate.

Of course they must be squashed, I asked this in the first comment.

Best regards,
Krzysztof