Re: [PATCH v4 5/5] platform/x86: acer-wmi: Ignore AC events

Kurt Borja
2024-12-10T02:16:50Z

On Tue, Dec 10, 2024 at 01:16:57AM +0100, Armin Wolf wrote:
> On the Acer Swift SFG14-41, the events 8 - 1 and 8 - 0 are printed on
> AC connect/disconnect. Ignore those events to avoid spamming the
> kernel log with error messages.

I noticed acer_thermal_profile_change() behavior changed whether the
laptop was on AC or not. Maybe users expect some kind of behavior around
thermal profiles with this event? Like switching to low-power when not
on AC or something like that.

~ Kurt

>
> Reported-by: Farhan Anwar <farhan.anwar8@gmail.com>
> Closes: https://lore.kernel.org/platform-driver-x86/2ffb529d-e7c8-4026-a3b8-120c8e7afec8@gmail.com
> Tested-by: Rayan Margham <rayanmargham4@gmail.com>
> Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> drivers/platform/x86/acer-wmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index aad8eb0ddae5..ef26ec8d90ea 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -99,6 +99,7 @@ enum acer_wmi_event_ids {
> WMID_HOTKEY_EVENT = 0x1,
> WMID_ACCEL_OR_KBD_DOCK_EVENT = 0x5,
> WMID_GAMING_TURBO_KEY_EVENT = 0x7,
> + WMID_AC_EVENT = 0x8,
> };
>
> enum acer_wmi_predator_v4_sys_info_command {
> @@ -2304,6 +2305,9 @@ static void acer_wmi_notify(union acpi_object *obj, void *context)
> if (return_value.key_num == 0x5 && has_cap(ACER_CAP_PLATFORM_PROFILE))
> acer_thermal_profile_change();
> break;
> + case WMID_AC_EVENT:
> + /* We ignore AC events here */
> + break;
> default:
> pr_warn("Unknown function number - %d - %d\n",
> return_value.function, return_value.key_num);
> --
> 2.39.5
>