Re: [PATCH v4 1/5] platform/x86: acer-wmi: Add support for Acer PH14-51

Kurt Borja
2024-12-10T02:09:48Z

On Tue, Dec 10, 2024 at 01:16:53AM +0100, Armin Wolf wrote:
> Add the Acer Predator PT14-51 to acer_quirks to provide support
> for the turbo button and predator_v4 hwmon interface.

Reviewed-by: Kurt Borja <kuurtb@gmail.com>

>
> Reported-by: Rayan Margham <rayanmargham4@gmail.com>
> Closes: https://lore.kernel.org/platform-driver-x86/CACzB==6tUsCnr5musVMz-EymjTUCJfNtKzhMFYqMRU_h=kydXA@mail.gmail.com
> Tested-by: Rayan Margham <rayanmargham4@gmail.com>
> Signed-off-by: Armin Wolf <W_Armin@gmx.de>
> ---
> drivers/platform/x86/acer-wmi.c | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
> index d09baa3d3d90..5cff538ee67f 100644
> --- a/drivers/platform/x86/acer-wmi.c
> +++ b/drivers/platform/x86/acer-wmi.c
> @@ -393,6 +393,13 @@ static struct quirk_entry quirk_acer_predator_ph315_53 = {
> .gpu_fans = 1,
> };
>
> +static struct quirk_entry quirk_acer_predator_pt14_51 = {
> + .turbo = 1,
> + .cpu_fans = 1,
> + .gpu_fans = 1,
> + .predator_v4 = 1,
> +};
> +
> static struct quirk_entry quirk_acer_predator_v4 = {
> .predator_v4 = 1,
> };
> @@ -600,6 +607,15 @@ static const struct dmi_system_id acer_quirks[] __initconst = {
> },
> .driver_data = &quirk_acer_predator_v4,
> },
> + {
> + .callback = dmi_matched,
> + .ident = "Acer Predator PT14-51",
> + .matches = {
> + DMI_MATCH(DMI_SYS_VENDOR, "Acer"),
> + DMI_MATCH(DMI_PRODUCT_NAME, "Predator PT14-51"),
> + },
> + .driver_data = &quirk_acer_predator_pt14_51,
> + },
> {
> .callback = set_force_caps,
> .ident = "Acer Aspire Switch 10E SW3-016",
> --
> 2.39.5
>