From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751213AbdAWLIf (ORCPT <rfc822;w@1wt.eu>);
        Mon, 23 Jan 2017 06:08:35 -0500
Received: from mout.web.de ([212.227.15.14]:54925 "EHLO mout.web.de"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751042AbdAWLIc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 23 Jan 2017 06:08:32 -0500
Subject: Re: KVM: s390: Move two error code assignments in
 kvm_vm_ioctl_get_dirty_log()
To: =?UTF-8?Q?Christian_Borntr=c3=a4ger?= <borntraeger@de.ibm.com>,
        kvm@vger.kernel.org, linux-s390@vger.kernel.org
References: <70f41e59-d8a4-de42-6064-80ecf6acc065@users.sourceforge.net>
 <35411200-2bd6-1c65-7d7f-21a6353875ea@de.ibm.com>
Cc: Cornelia Huck <cornelia.huck@de.ibm.com>,
        Heiko Carstens <heiko.carstens@de.ibm.com>,
        Martin Schwidefsky <schwidefsky@de.ibm.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
From: SF Markus Elfring <elfring@users.sourceforge.net>
Message-ID: <01d581bb-9db6-cba1-e476-49c814c3ebf0@users.sourceforge.net>
Date: Mon, 23 Jan 2017 12:08:12 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <35411200-2bd6-1c65-7d7f-21a6353875ea@de.ibm.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-Provags-ID: V03:K0:7uDr6gg0/pCLfVfA0hPz/Co8NNmISb83U5+Cxe1woZ6epzWknmW
 BozWYAzgjVXVf/1f45qSD1TTtT1SnMKV8G1mDnqsf3j6p4sNMNTXs4HUGyTis9MHO+dACE0
 8fl+bVqmFnKMJ28t/MGLXfAmGGNRd7u/LlKwu5fRcNeWfXgvLqMfRIV8/qviMkEJvdZQF7O
 3Hw/o16WddOT2xnJ+aMvQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:F9PhNGzhPyo=:BsiJH1jIPMq5kzeIGeS5sX
 Rdf/xRE401j3EMTZSJ4S/GJEZfVbI94YnHuV/JN/uaL9RfNmheuaglftcYm3etlvCNkmWetEE
 GVmwaxW5cXidcqi/nm6EOWuXWCXNlp6Q58GmSBedQY7GOEsr2BM3nbwkhhhMOGh/B+1d+BAS+
 1yFcRHZWGe2VScRVw6xUUw0J9wDA9wNokEJQk+dip5isVtpYTqdgyOpqbZfmWZzK99woBaZIo
 c6RkIb4j/btD8FGFJRp3M4XnGGs/0NDVtuIm/m+vCAYY/b3LdhHDvHmGuxvCKvsfYCPdXVk1Y
 VMnorD1V5mB6h3RyF1Ua5g4l82DK2RJszl3o9DM54AyUkv5Tm5w5Vt0WiZ/UW+3Pv5N/YEWOX
 0rSvy1mPkFUr2rQe57io262j2gTvXIqqlZm3rwNF2KvD5u+j4wp7hPvd1Ri2n0oJbNWgntqlC
 t0fV3ggT/Dk66P5mYsqUTnhTYmPNh2hpdWRK8+9a/570t9wuk3rRlskcJOscWF8flKKMSojOo
 PAM8brpEJYgTKTDGaVROODvm/EUu2H1UU2+cAy95Pp6WW+eMf7zrl71IJtnMp+/akBL64VfuG
 4qriv7tYpdbg8Rs5sDTQKJ2l+BII7La1X/kVKkoSULaBV9zC6wbowY+tZx9YlwNqGNSZRslRk
 RaNP1oO///ld2zsQjgB+kiSlgWqjUWnDMQsaZydrnQRlGgBrqTPdPHy78uBu0zrjFdCvCQrC6
 VWu7LtPR1qnsCKMbro+2hZqA8q0Ve3LHDwJKsKOGkCHNIseVWkqlxXv26XRZ3j8skVBpO09lQ
 INY21pT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> Patches that changes open coded things to common helpers or things like
> kmalloc_array where appropriate or things that make the code more robust
> are fine and welcome, but I am not going to take this as it just shuffles
> things around.

Thanks for such information.


> It does not fix anything and it does not improve the code,

I have got an other expectation for the shown implementation detail.


> but it certainly carries the risk of breaking something

This is usual in software development, isn't it?


> (yes in this case it looks perfectly fine, though).

Thanks for this bit of positive feedback.


> Due to the locking requirements we cannot do such a simplification here.

I find this detail strange. Would you like to check run time consequences
for the shown error code settings once more?

Regards,
Markus