From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752567AbdBXDa3 (ORCPT ); Thu, 23 Feb 2017 22:30:29 -0500 Received: from out0-146.mail.aliyun.com ([140.205.0.146]:52394 "EHLO out0-146.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751824AbdBXDaY (ORCPT ); Thu, 23 Feb 2017 22:30:24 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R141e4;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e02c03307;MF=hillf.zj@alibaba-inc.com;NM=1;PH=DS;RN=11;SC=85;SR=0;TI=SMTPD_---.7hAEJ76_1487906995; Reply-To: "Hillf Danton" From: "Hillf Danton" To: "'Shaohua Li'" , , Cc: , , , , , , , References: <6e99fbb58c019dac280dde73a96586c0eba880d0.1487788131.git.shli@fb.com> In-Reply-To: <6e99fbb58c019dac280dde73a96586c0eba880d0.1487788131.git.shli@fb.com> Subject: Re: [PATCH V4 1/6] mm: delete unnecessary TTU_* flags Date: Fri, 24 Feb 2017 11:29:54 +0800 Message-ID: <01d601d28e4e$44a43090$cdec91b0$@alibaba-inc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQJHEb4HguBM/13H0tBzC17uzgcDAwMLKNqwoHYfRaA= Content-Language: zh-cn Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On February 23, 2017 2:51 AM Shaohua Li wrote: > > Johannes pointed out TTU_LZFREE is unnecessary. It's true because we > always have the flag set if we want to do an unmap. For cases we don't > do an unmap, the TTU_LZFREE part of code should never run. > > Also the TTU_UNMAP is unnecessary. If no other flags set (for > example, TTU_MIGRATION), an unmap is implied. > > Cc: Michal Hocko > Cc: Minchan Kim > Cc: Hugh Dickins > Cc: Rik van Riel > Cc: Mel Gorman > Cc: Andrew Morton > Suggested-by: Johannes Weiner > Signed-off-by: Shaohua Li > --- Acked-by: Hillf Danton