From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 04C803009FC for ; Tue, 18 Nov 2025 08:59:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763456346; cv=none; b=jLlUgWKucHl6K9zu8SrARosE+bQ0wJYpWXo/qIxLluc2GF8wdFR5JGKSiSm6J7jlpWDTshDyEpXv3ca3z8EfalU3I4guruQLwcFXE8+H4R6NCEWOOLhFc8/bHqwEzqQ2xn1yEujvWPaAn9lmdlCO4cC7ri8mRPPdpyS8g/G/Q+A= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763456346; c=relaxed/simple; bh=x/mAy1pSvtCBQglAzNSwziWbAmyz733c9ABBqKUw2PE=; h=Message-ID:Date:MIME-Version:To:Cc:References:Subject:From: In-Reply-To:Content-Type; b=S44/HAg8m5R4E1SnMG1Zhn880IOTTdIgAtGqqLpvYogcmC6SMR/bY+q881dN9obfehm/vACgd6y1noQ8leY8KwXHXswnmvz9O+3icg5EgtbNlhRy/AwAfweaRX3dlemCRVV0Z3E+PltyICBM3tRcIxzsAPVT0FBVhqTwmzj7aqA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=OZVQiB7p; arc=none smtp.client-ip=209.85.214.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OZVQiB7p" Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-29555b384acso53770675ad.1 for ; Tue, 18 Nov 2025 00:59:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763456344; x=1764061144; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language:subject :references:cc:to:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=KUmPskdfxU4Pzdy7Qbg/7BrxTe0Dl4lbyRxjql3bTZg=; b=OZVQiB7pmd2G1YgOOVT4FWxMKnFDfMT7SvrFHiAiF5sclB2QJV31LHQtUuEzDmCzez uN7v3XL4CUU4+UHY0o2u0o9cU0+Smb6o/ZRCKZDLxaPAs70SN8LnMgSHIg7DS9vE4DHH Q7YWNO1vuiK3xJrPCdh1uCp/Ek2yxmnp/k1djsW31nkWoAS2/oO23Y31nKB4jasKNtZD Kb9/3aB4B+POxv3YeERhlinuqTbbEq/SgKz9vF3n9uzmt2wZYtsOdm4RwF2p6lMZUJTl Ssg3/YQffCZO9YzISt+emnEsiU7KArVdGJuDHTKSKO6vYOHlkjskiOtIo5EnlBicpdp7 Gc0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763456344; x=1764061144; h=content-transfer-encoding:in-reply-to:from:content-language:subject :references:cc:to:user-agent:mime-version:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=KUmPskdfxU4Pzdy7Qbg/7BrxTe0Dl4lbyRxjql3bTZg=; b=VCIqIVwMd+WsVaKr1AnvzX39qP9DJJC1ayS9HRlbdVC54p7to5RR7i4ClKa5iVoOI/ pW0ueDPrEvw3ivGiyIDdfXdoT6gH3RVtNH5zacnpQ8d3trTB6q/jH7BROiTJy/6FD1H4 UsEM/cTvH77PV0mIvmf2ecg7aBqZVTOSzXJFM9FmUUpD5Dlzy1RBisKOgl4jqWRE5OHu ujBtHPO/xJ+NJp8Xrbs7DVwNJwto1igE7mKiZR6JKhNBXfe7LHhBF/Km8uIhGj3Uu10D UQHUo0yAg6NM6Lr4zakRp4iEKCzm/ub9ya0tNoV9UFeXsojaNO564s9+S1FW9IvuJNkc c/pg== X-Forwarded-Encrypted: i=1; AJvYcCU8PQ4O1SqZSiwxLE4QuZUgp8Jg8Sr2dlRpSbPdzu4+wVe6w8M+7siY4LX8mfIf9NBqCipFsoY0IZkxNDQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yw5IacVRwt9zJmwN8PAJcf/G2yzNzZqsmzcrKvAmd2Kf9wfW02v tp4XwAK10mqMe0rcC5uDh7CwimuG8EALqTImNl5Kzgg2FENy71sG6eER X-Gm-Gg: ASbGncsiL2AsrawsJ3hVVJj0SUcAyqV2Pq5aYsOI65BRRSlxUeiY+tAavW+6FUFFGup DoB23lRANNLLDBkySaQl3ffLBZNK5kEm7u8U12IRZ6CN+rl5xdWTuDZ+5RsERMQ9HH7T9LLHQPz WzydROYhkB7qoFmZAb4cTAdtbT+GjGlououmsb7fCG8O/lTK5O2XJfa8pOHXxfKU0CHPNL6qMhR dNOsrxAIvQSlKAR7gKsj4+W9a5PfUY2iKoa8TkdgkRkn6UxTksveq3//FWJDjGd0p2LmjLjq2N/ yA2U6/CZ6B4d+CYtSMBo3tXovsYQ7kY4Gerpl9RVkqDGZTzpmLaBGyi58fwm79yEZjmVNae8Chy POGfpK5QtKlykdx3bQDwALq0E5bi96mkfWoejO+QnmgWm5Vluhiv/h/C0zuNFpJl8pyu6tKCGQN J3iiyUA/PpT1bLgtpciEJL9hhU1VqmhDri7OdQE4jx+XighOB5XeR0sJWs95KW2MU= X-Google-Smtp-Source: AGHT+IHgh6PA6G1apHM+ako1vThMywJAXh+PHpqQQ44eccqRbaXMC9mM8B44cHmHC93roIZ9Q9hyzA== X-Received: by 2002:a17:902:e551:b0:295:6427:87e4 with SMTP id d9443c01a7336-2986a750a0emr193171945ad.40.1763456344102; Tue, 18 Nov 2025 00:59:04 -0800 (PST) Received: from ?IPV6:2405:201:31:d869:97fc:5352:f5a:57af? ([2405:201:31:d869:97fc:5352:f5a:57af]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2985c249806sm165613565ad.44.2025.11.18.00.59.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 Nov 2025 00:59:03 -0800 (PST) Message-ID: <01e16af7-4f76-40eb-89c2-79386850d756@gmail.com> Date: Tue, 18 Nov 2025 14:28:59 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: syzbot+87be6809ed9bf6d718e3@syzkaller.appspotmail.com Cc: linux-cifs@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com References: <69155df4.a70a0220.3124cb.0016.GAE@google.com> Subject: Re: [syzbot] [cifs?] memory leak in smb3_fs_context_fullpath Content-Language: en-US From: shaurya In-Reply-To: <69155df4.a70a0220.3124cb.0016.GAE@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit #syz test: git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master diff --git a/fs/smb/client/fs_context.c b/fs/smb/client/fs_context.c index 0f894d09157b..975f1fa153fd 100644 --- a/fs/smb/client/fs_context.c +++ b/fs/smb/client/fs_context.c @@ -1834,6 +1834,12 @@ static int smb3_fs_context_parse_param(struct fs_context *fc,      ctx->password = NULL;      kfree_sensitive(ctx->password2);      ctx->password2 = NULL; +    kfree(ctx->source); +    ctx->source = NULL; +    if (fc) { +        kfree(fc->source); +        fc->source = NULL; +    }      return -EINVAL;  }