RE: [PATCH V3 3/7] mfd: samsung: Modify samsung mfd header

Sangbeom Kim
2012-07-12T22:30:15Z

Hi!
On Wednesday, July 11, 2012 9:30 PM, Venu Byravarasu wrote:

> > + * copyright (c) 2011 Samsung Electronics Co., Ltd
> > + * http://www.samsung.com
>
> In most of the files you mentioned 2011.
> Should they not be changed to 2012?

Most of the files are created in 2011.
This file is moved from include/linux/mfd/s5m87xx/s5m-core.h

> > - int buck_set1;
> > - int buck_set2;
> > - int buck_set3;
>
> As you have buck4_enable etc below, by any chance do you need buck_set4 as well here?

No, S5M8767 have 3 controllerble gpios.
The purpose of buck_set1,2,3 is each gpio control.
To handle 3 gpio, I had added buck_set1, buck_set2, buck_set3.

> Similarly should you declare buck1_enable here?

No, gpio control can be enabled on buck2, buck3, buck4.
There is no need buck1_enable.

> > - int buck2_enable;
> > - int buck3_enable;
> > - int buck4_enable;
> > - int buck_default_idx;
> > - int buck2_default_idx;

Thanks,
Sangbeom.