From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: YijieYang <quic_yijiyang@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
quic_tingweiz@quicinc.com, quic_aiquny@quicinc.com
Subject: Re: [PATCH v2 3/5] arm64: dts: qcom: qcs8300-ride: enable ethernet0
Date: Fri, 25 Oct 2024 19:53:23 +0200 [thread overview]
Message-ID: <01ed914a-bed8-4d9f-9ff4-56b4fc8bc0b4@oss.qualcomm.com> (raw)
In-Reply-To: <20241017102728.2844274-4-quic_yijiyang@quicinc.com>
On 17.10.2024 12:27 PM, YijieYang wrote:
> From: Yijie Yang <quic_yijiyang@quicinc.com>
>
> Enable the SerDes PHY on qcs8300-ride.
> Add the MDC and MDIO pin functions for ethernet0 on qcs8300-ride.
> Enable the first 1Gb ethernet port on qcs8300-ride development board.
>
> Signed-off-by: Yijie Yang <quic_yijiyang@quicinc.com>
> ---
[...]
> +
> +&tlmm {
> + ethernet0_default: ethernet0-default-state {
> + ethernet0_mdc: ethernet0-mdc-pins {
If you don't intend to modify these specific configs, you can drop
the labels from child pin nodes
The rest looks good
Generally refactors happen first and features are added later, but
I know how painful it is to reorder changes in a patchset, so I'm
not going to ask you to do that.
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Konrad
next prev parent reply other threads:[~2024-10-25 17:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-17 10:27 [PATCH v2 0/5] Enable ethernet for qcs8300 YijieYang
2024-10-17 10:27 ` [PATCH v2 1/5] dt-bindings: arm: qcom: add qcs8300-ride Rev 2 YijieYang
2024-10-18 6:24 ` Krzysztof Kozlowski
2024-10-17 10:27 ` [PATCH v2 2/5] arm64: dts: qcom: qcs8300: add the first 1Gb ethernet YijieYang
2024-10-17 10:27 ` [PATCH v2 3/5] arm64: dts: qcom: qcs8300-ride: enable ethernet0 YijieYang
2024-10-25 17:53 ` Konrad Dybcio [this message]
2024-10-17 10:27 ` [PATCH v2 4/5] arm64: dts: qcom: move common parts for qcs8300-ride variants into a .dtsi YijieYang
2024-10-25 17:55 ` Konrad Dybcio
2024-10-28 1:20 ` Yijie Yang
2024-10-17 10:27 ` [PATCH v2 5/5] arm64: dts: qcom: qcs8300-ride-r2: add new board file YijieYang
2024-10-25 17:55 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01ed914a-bed8-4d9f-9ff4-56b4fc8bc0b4@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=quic_aiquny@quicinc.com \
--cc=quic_tingweiz@quicinc.com \
--cc=quic_yijiyang@quicinc.com \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox