From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from canpmsgout09.his.huawei.com (canpmsgout09.his.huawei.com [113.46.200.224]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA63A248F7C for ; Fri, 8 May 2026 02:26:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=113.46.200.224 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778207220; cv=none; b=XPW1UZKGDfk1Z1AZ4xFh///tsPi6oJyAWWva7su4vUvrHN5wPVBgf8kdvSJ6327kR2c3KOYh3qAzUouCvi5ZrC92KjKXAj/KD8Ib3Efa2EFjP2Tofg25glawNxRpd485UBM1gpPQnCy+1vaiQzBS4pUdEGhZoz4a0wKQQXNYxlM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778207220; c=relaxed/simple; bh=slIVphLDneFEAIHPWGq0i4Xyt8uYMdw/7pli/+/K2xA=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=HgaoFFk6edMcm+ymU57TanAe8mvc60q2raym0uI4f+bmjW2hBBI1E6LL6fU1Xy6VcY/ZqN+6CEBgd1Bqhm0gUfI9YRw7QyPgaidJX0p/iO13FYhT9VLHM3jTAYZ2EfBzmOxO1udTbCdVinY4f5ExMyiyJJ2tp8pVxALXh24TI+8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com; spf=pass smtp.mailfrom=h-partners.com; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b=jWrlmnmP; arc=none smtp.client-ip=113.46.200.224 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=huawei.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=h-partners.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=h-partners.com header.i=@h-partners.com header.b="jWrlmnmP" dkim-signature: v=1; a=rsa-sha256; d=h-partners.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=FFoto0CQ6rg+RgoG9007lSvv//zhS03O/RO7gbpH3X4=; b=jWrlmnmPbPCBH38GdvP9OjZDfpJAb5gtkciJKDHVW4JDUnXGYrOUpKSFIK0BUZi+7xHCyDm6D 9UHYbhivy+AXbnKfpk0Iibww2bQrUNU2zA9Ev0cdxtfs5jpFS7NQIpXDrRicevq8Z17DR+OOauT 9lOgp1is9lkbt6BK8mcueSI= Received: from mail.maildlp.com (unknown [172.19.163.200]) by canpmsgout09.his.huawei.com (SkyGuard) with ESMTPS id 4gBXqr3mVlz1cyQr; Fri, 8 May 2026 10:19:20 +0800 (CST) Received: from kwepemf100008.china.huawei.com (unknown [7.202.181.222]) by mail.maildlp.com (Postfix) with ESMTPS id 1C7254055B; Fri, 8 May 2026 10:26:53 +0800 (CST) Received: from [10.174.179.37] (10.174.179.37) by kwepemf100008.china.huawei.com (7.202.181.222) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Fri, 8 May 2026 10:26:51 +0800 Message-ID: <01ef61ca-7ba7-b282-7ec6-b1df5c301aa5@huawei.com> Date: Fri, 8 May 2026 10:26:50 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 2/2] arm_mpam: Update architecture version check for MPAM MSC Content-Language: en-US To: James Morse , , , , , , , , , , , , , , , , , , , , , , , , CC: , , References: <20260203095406.6437-1-zengheng4@huawei.com> <20260203095406.6437-3-zengheng4@huawei.com> From: Zeng Heng In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: kwepems500001.china.huawei.com (7.221.188.70) To kwepemf100008.china.huawei.com (7.202.181.222) Hi James, On 2026/5/8 0:03, James Morse wrote: > Hi Zeng, > > On 03/02/2026 09:54, Zeng Heng wrote: >> In addition to updating the CPU MPAM version check, the MPAM MSC version >> check also need to be updated. mpam_msc_check_aidr() is added to check >> the MSC AIDR register, ensuring that both the major and minor version >> numbers fall within the supported range of the MPAM architecture version. > >> diff --git a/drivers/resctrl/mpam_devices.c b/drivers/resctrl/mpam_devices.c >> index 744df3a6a078..a58031f0a280 100644 >> --- a/drivers/resctrl/mpam_devices.c >> +++ b/drivers/resctrl/mpam_devices.c >> @@ -202,6 +202,17 @@ static inline void _mpam_write_monsel_reg(struct mpam_msc *msc, u16 reg, u32 val >> >> #define mpam_write_monsel_reg(msc, reg, val) _mpam_write_monsel_reg(msc, MSMON_##reg, val) >> >> +static bool mpam_msc_check_aidr(struct mpam_msc *msc) >> +{ >> + u32 rev; >> + >> + rev = __mpam_read_reg(msc, MPAMF_AIDR) & MPAMF_AIDR_ARCH_REV; >> + >> + return rev == MPAM_ARCHITECTURE_V0_1 || >> + rev == MPAM_ARCHITECTURE_V1_0 || >> + rev == MPAM_ARCHITECTURE_V1_1; >> +} >> + >> static u64 mpam_msc_read_idr(struct mpam_msc *msc) >> { >> u64 idr_high = 0, idr_low; >> @@ -842,9 +853,8 @@ static int mpam_msc_hw_probe(struct mpam_msc *msc) >> >> lockdep_assert_held(&msc->probe_lock); >> >> - idr = __mpam_read_reg(msc, MPAMF_AIDR); >> - if ((idr & MPAMF_AIDR_ARCH_MAJOR_REV) != MPAM_ARCHITECTURE_V1) { >> - dev_err_once(dev, "MSC does not match MPAM architecture v1.x\n"); > > This deliberately only checks the major number. (The MSC architecture always had a > major and minor number). Before your change, MPAM v1.2 is supported, after we'd > get an error for a MPAM v1.2 MSC. (if such a thing exists) > > I think its simpler to rule out the unsupported combinations, something like: > | static bool mpam_msc_check_aidr(struct mpam_msc *msc) > | { > | u32 rev; > | > | rev = __mpam_read_reg(msc, MPAMF_AIDR) & MPAMF_AIDR_ARCH_REV; > | > | /* > | * v0.0 and >v2.x aren't supported, but anything else should be backward > | * compatible to v0.1 or v1.0. > | */ > | if (!rev) > | return false; > | if (rev & MPAMF_AIDR_ARCH_MAJOR_REV > MPAM_ARCHITECTURE_V1) > | return false; > | > | return true; > | } > >> + if (!mpam_msc_check_aidr(msc)) { >> + dev_err_once(dev, "MSC does not match MPAM architecture\n"); >> return -EIO; >> } > > I'd like to keep the 'v1.x' in this message - this should help folk with old stable > kernels running on new hardware work out why the feature isn't available. > (assuming they have some documentation that says v2.0 in it!) > > I've rebased this with the above changes, which I'll post shortly for fixes. > > Agreed. Keep the backward compatibility extension for versions (compatible with v0.x(x>0) and 1.x), and remove the redundant MPAM_ARCHITECTURE_Vx_x macro definitions. I've verified locally that everything works fine. Best regards, Zeng Heng