From: Jingoo Han <jg1.han@samsung.com>
To: "'Andrew Morton'" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, "'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH] lib: devres: Fix misplaced #endif
Date: Mon, 25 Feb 2013 11:13:14 +0900 [thread overview]
Message-ID: <01f301ce12fd$ab3fe400$01bfac00$%han@samsung.com> (raw)
In-Reply-To: <20130222134418.a86e78b1.akpm@linux-foundation.org>
On Saturday, February 23, 2013 6:44 AM, Andrew Morton wrote:
>
> On Fri, 22 Feb 2013 14:39:40 +0900
> Jingoo Han <jg1.han@samsung.com> wrote:
>
> > A misplaced #endif causes link errors related to pcim_*() functions.
> >
> > --- a/lib/devres.c
> > +++ b/lib/devres.c
> > @@ -227,6 +227,7 @@ void devm_ioport_unmap(struct device *dev, void __iomem *addr)
> > devm_ioport_map_match, (void *)addr));
> > }
> > EXPORT_SYMBOL(devm_ioport_unmap);
> > +#endif /* CONFIG_HAS_IOPORT */
> >
> > #ifdef CONFIG_PCI
> > /*
> > @@ -432,4 +433,3 @@ void pcim_iounmap_regions(struct pci_dev *pdev, int mask)
> > }
> > EXPORT_SYMBOL(pcim_iounmap_regions);
> > #endif /* CONFIG_PCI */
> > -#endif /* CONFIG_HAS_IOPORT */
>
> More details needed, please. This code is pretty old and it's
> surprising that errors are popping up now.
OK, I will add more detailed commit message.
Thank you.
Best regards,
Jingoo Han
next prev parent reply other threads:[~2013-02-25 2:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 5:39 [PATCH] lib: devres: Fix misplaced #endif Jingoo Han
2013-02-22 21:44 ` Andrew Morton
2013-02-25 2:13 ` Jingoo Han [this message]
2013-02-25 2:20 ` [PATCH V2] " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='01f301ce12fd$ab3fe400$01bfac00$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox