From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Alien Wesley <alienwesley51@gmail.com>,
gregkh@linuxfoundation.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org, ~lkcamp/patches@lists.sr.ht
Subject: Re: [PATCH] staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529
Date: Sun, 25 Aug 2024 19:35:43 +0200 [thread overview]
Message-ID: <01f4337d-baff-4df6-9367-3e9cf2fe32d1@gmail.com> (raw)
In-Reply-To: <20240825154557.17912-1-alienwesley51@gmail.com>
On 8/25/24 17:45, Alien Wesley wrote:
> Separated assignments for pairwise_key_type and group_key_type
> in order to silence the following checkpatch warning.
>
> CHECK: multiple assignments should be avoided.
>
> Signed-off-by: Alien Wesley <alienwesley51@gmail.com>
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> index fc8e7f73b2a4..47f1adf30ab4 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c
> @@ -526,7 +526,8 @@ static int _rtl92e_wx_set_enc(struct net_device *dev,
> mutex_unlock(&priv->wx_mutex);
>
> if (wrqu->encoding.flags & IW_ENCODE_DISABLED) {
> - ieee->pairwise_key_type = ieee->group_key_type = KEY_TYPE_NA;
> + ieee->pairwise_key_type = KEY_TYPE_NA;
This line contains two spaces in front of "=".
> + ieee->group_key_type = KEY_TYPE_NA;
> rtl92e_cam_reset(dev);
> memset(priv->rtllib->swcamtable, 0,
> sizeof(struct sw_cam_table) * 32);
next prev parent reply other threads:[~2024-08-25 17:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-25 15:45 [PATCH] staging: rtl8192e: Fix multiple assignments in rtl_wx.c:529 Alien Wesley
2024-08-25 17:35 ` Philipp Hortmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-08-25 21:46 Alien Wesley
2024-08-25 22:43 ` Alien Wesley
2024-08-26 0:42 ` Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01f4337d-baff-4df6-9367-3e9cf2fe32d1@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=alienwesley51@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=~lkcamp/patches@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox