* [PATCH] mtd: nand: MTD_NAND_ECC_REALTEK should depend on HAS_DMA
@ 2025-10-08 9:47 Geert Uytterhoeven
2025-10-08 12:57 ` AW: " markus.stockhausen
2025-10-22 9:56 ` Miquel Raynal
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2025-10-08 9:47 UTC (permalink / raw)
To: Markus Stockhausen, Miquel Raynal, Richard Weinberger,
Vignesh Raghavendra
Cc: linux-mtd, linux-kernel, Geert Uytterhoeven
If CONFIG_NO_DMA=y:
ERROR: modpost: "dma_free_pages" [drivers/mtd/nand/ecc-realtek.ko] undefined!
ERROR: modpost: "dma_alloc_pages" [drivers/mtd/nand/ecc-realtek.ko] undefined!
The driver cannot function without DMA, hence fix this by adding a
dependency on HAS_DMA.
Fixes: 3148d0e5b1c5733d ("mtd: nand: realtek-ecc: Add Realtek external ECC engine support")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
drivers/mtd/nand/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index 4a17271076bc1c4a..1e57c8de857825d7 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -63,7 +63,7 @@ config MTD_NAND_ECC_MEDIATEK
config MTD_NAND_ECC_REALTEK
tristate "Realtek RTL93xx hardware ECC engine"
- depends on HAS_IOMEM
+ depends on HAS_IOMEM && HAS_DMA
depends on MACH_REALTEK_RTL || COMPILE_TEST
select MTD_NAND_ECC
help
--
2.43.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* AW: [PATCH] mtd: nand: MTD_NAND_ECC_REALTEK should depend on HAS_DMA
2025-10-08 9:47 [PATCH] mtd: nand: MTD_NAND_ECC_REALTEK should depend on HAS_DMA Geert Uytterhoeven
@ 2025-10-08 12:57 ` markus.stockhausen
2025-10-22 9:56 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: markus.stockhausen @ 2025-10-08 12:57 UTC (permalink / raw)
To: 'Geert Uytterhoeven'
Cc: linux-mtd, linux-kernel, 'Miquel Raynal',
'Richard Weinberger', 'Vignesh Raghavendra'
> Von: Geert Uytterhoeven <geert@linux-m68k.org>
> Gesendet: Mittwoch, 8. Oktober 2025 11:47
>
> If CONFIG_NO_DMA=y:
>
> ERROR: modpost: "dma_free_pages" [drivers/mtd/nand/ecc-realtek.ko]
undefined!
> ERROR: modpost: "dma_alloc_pages" [drivers/mtd/nand/ecc-realtek.ko]
undefined!
>
> The driver cannot function without DMA, hence fix this by adding a
> dependency on HAS_DMA.
>
> Fixes: 3148d0e5b1c5733d ("mtd: nand: realtek-ecc: Add Realtek external ECC
engine support")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] mtd: nand: MTD_NAND_ECC_REALTEK should depend on HAS_DMA
2025-10-08 9:47 [PATCH] mtd: nand: MTD_NAND_ECC_REALTEK should depend on HAS_DMA Geert Uytterhoeven
2025-10-08 12:57 ` AW: " markus.stockhausen
@ 2025-10-22 9:56 ` Miquel Raynal
1 sibling, 0 replies; 3+ messages in thread
From: Miquel Raynal @ 2025-10-22 9:56 UTC (permalink / raw)
To: Markus Stockhausen, Richard Weinberger, Vignesh Raghavendra,
Geert Uytterhoeven
Cc: linux-mtd, linux-kernel
On Wed, 08 Oct 2025 11:47:15 +0200, Geert Uytterhoeven wrote:
> If CONFIG_NO_DMA=y:
>
> ERROR: modpost: "dma_free_pages" [drivers/mtd/nand/ecc-realtek.ko] undefined!
> ERROR: modpost: "dma_alloc_pages" [drivers/mtd/nand/ecc-realtek.ko] undefined!
>
> The driver cannot function without DMA, hence fix this by adding a
> dependency on HAS_DMA.
>
> [...]
Applied to mtd/fixes, thanks!
[1/1] mtd: nand: MTD_NAND_ECC_REALTEK should depend on HAS_DMA
commit: 0d9c80aa572182d4b1464826cd77aa8973213216
Patche(s) should be available on mtd/linux.git and will be
part of the next PR (provided that no robot complains by then).
Kind regards,
Miquèl
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-10-22 9:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-08 9:47 [PATCH] mtd: nand: MTD_NAND_ECC_REALTEK should depend on HAS_DMA Geert Uytterhoeven
2025-10-08 12:57 ` AW: " markus.stockhausen
2025-10-22 9:56 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox