public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: Wilfred Mallawa <wilfred.opensource@gmail.com>
Cc: bhelgaas@google.com,
	Mika Westerberg <mika.westerberg@linux.intel.com>,
	 sathyanarayanan.kuppuswamy@linux.intel.com,
	Lukas Wunner <lukas@wunner.de>,
	 linux-pci@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	 alistair.francis@wdc.com, wilfred.mallawa@wdc.com,
	dlemoal@kernel.org,  cassel@kernel.org
Subject: Re: [PATCH v2] PCI: fix the printed delay amount in info print
Date: Mon, 14 Apr 2025 16:01:21 +0300 (EEST)	[thread overview]
Message-ID: <01ff78f6-0708-4556-1fce-69250d625b2b@linux.intel.com> (raw)
In-Reply-To: <20250414001505.21243-2-wilfred.opensource@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1197 bytes --]

On Mon, 14 Apr 2025, Wilfred Mallawa wrote:

> From: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> 
> Print the delay amount that pcie_wait_for_link_delay() is invoked with
> instead of the hardcoded 1000ms value in the debug info print.
> 
> Fixes: 7b3ba09febf4 ("PCI/PM: Shorten pci_bridge_wait_for_secondary_bus() wait time for slow links")
> Signed-off-by: Wilfred Mallawa <wilfred.mallawa@wdc.com>
> Reviewed-by: Damien Le Moal <dlemoal@kernel.org>
> ---
>  drivers/pci/pci.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> index 869d204a70a3..8139b70cafa9 100644
> --- a/drivers/pci/pci.c
> +++ b/drivers/pci/pci.c
> @@ -4935,7 +4935,7 @@ int pci_bridge_wait_for_secondary_bus(struct pci_dev *dev, char *reset_type)
>  		delay);
>  	if (!pcie_wait_for_link_delay(dev, true, delay)) {
>  		/* Did not train, no need to wait any further */
> -		pci_info(dev, "Data Link Layer Link Active not set in 1000 msec\n");
> +		pci_info(dev, "Data Link Layer Link Active not set in %d msec\n", delay);
>  		return -ENOTTY;
>  	}
>  
> 

Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>

-- 
 i.

  parent reply	other threads:[~2025-04-14 13:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-14  0:15 [PATCH v2] PCI: fix the printed delay amount in info print Wilfred Mallawa
2025-04-14  0:46 ` Sathyanarayanan Kuppuswamy
2025-04-14  4:40 ` Mika Westerberg
2025-04-14 13:01 ` Ilpo Järvinen [this message]
2025-04-17 20:26 ` Bjorn Helgaas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=01ff78f6-0708-4556-1fce-69250d625b2b@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=alistair.francis@wdc.com \
    --cc=bhelgaas@google.com \
    --cc=cassel@kernel.org \
    --cc=dlemoal@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=mika.westerberg@linux.intel.com \
    --cc=sathyanarayanan.kuppuswamy@linux.intel.com \
    --cc=wilfred.mallawa@wdc.com \
    --cc=wilfred.opensource@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox