From: "Ivan G." <ivangurdiev@linuxfreemail.com>
To: Roger Luethi <rl@hellgate.ch>
Cc: Urban Widmark <urban@teststation.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] VIA Rhine stalls: TxAbort handling
Date: Wed, 15 May 2002 15:52:35 -0600 [thread overview]
Message-ID: <02051515523500.01017@cobra.linux> (raw)
In-Reply-To: <20020514035318.GA20088@k3.hellgate.ch> <02051317475500.00917@cobra.linux> <20020516004927.GA13388@k3.hellgate.ch>
> I'll take that down as "The patch didn't break anything" <g>. Thanks.
:) Some nice day this card will work.
I know it. It's too bad I don't have time to mess with it right now.
> What I have seen: switching from eeprom default (AMD/MBA backoff on my
> card) to something else (as VIA does) slows things down, but the TxAborts
> are gone. Did you try different backoff algorithms?
The slowdown I was talking about was actually with the new abort/underrun
handling - I had tried it by myself before your patch. That's the what that
quote was about. I think I handled both Abort and Underrun like that.
I'll try that new patch that you're making to retest.
> Also, you may want to try if the backoff bit in TxConfig makes a difference
> for you (may be different with your chip, after all). It's not a one-liner
> like ConfigD, though, since TxConfig gets overwritten in several places.
> On a side note, I'm not particularly happy about the way we stomp all over
> TxConfig when we set the threshold. IMO we should leave the lower 5 bits
> alone.
No, I haven't messed with those bits, to answer Urban and your question.
I've only tried your patch which forces the backoff algortihm to AMD.
Tests sound like a good idea. I'll try something out when I have time - been
busy lately.
> The only data sheet I've seen for the VT86C100A agrees with the code, not
> the comment, so apparantly I don't have access to those more recent docs.
> This code is only used if you enable MMIO, though, which may not be a good
> idea if you already have problems with the driver.
On Urban's question, I test without MMIO so this is not a related issue. I
was merely curious since I don't feel comfortable trusting something which
A) does not match any of the other Rhine-based cards (2's and 3's)
B) says RESERVED in the docs which I have.
Funny, I was going to send you a link to the newer docs, but I ran into the
older ones which I had never seen before. Yes, they do agree with the current
code. Hmm. Perhaps we should ask VIA why it was changed...
next prev parent reply other threads:[~2002-05-16 3:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-14 3:53 [PATCH] VIA Rhine stalls: TxAbort handling Roger Luethi
2002-05-13 23:51 ` Ivan G.
2002-05-14 17:28 ` Urban Widmark
2002-05-16 0:49 ` Roger Luethi
2002-05-15 21:52 ` Ivan G. [this message]
2002-05-16 14:19 ` Roger Luethi
2002-05-14 0:03 ` Ivan G.
2002-05-14 14:11 ` Jeff Garzik
2002-05-14 15:08 ` Roger Luethi
2002-05-14 17:47 ` Urban Widmark
2002-05-16 0:51 ` Roger Luethi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02051515523500.01017@cobra.linux \
--to=ivangurdiev@linuxfreemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rl@hellgate.ch \
--cc=urban@teststation.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox