Re: EVMS Submission for 2.5

Greg KH
2002-10-02T22:40:53Z

On Wed, Oct 02, 2002 at 04:33:20PM -0500, Kevin Corry wrote:
>
> Thank you very much for taking the time to consider this
> submission. If you have any questions or comments, please email
> us at any time. We will be happy to do whatever is necessary to
> make EVMS acceptable for inclusion in the 2.5 tree.

Some comments on the code:
- you might want to post a patch with the whole evms portion of
the code, for those people without BitKeeper to see.
- The #ifdef EVMS_DEBUG lines are still in AIXlvm_vge.c, I
thought you said you were going to fix this file up?
- The OS2 and S390 files don't look like they have been fixed,
like you said you would before submission.
- evms_ecr.h and evms_linear.h have a lot of unneeded typedefs.
- the md code duplication has not been addressed, as you said it
would be.
- the BK repository contains a _lot_ of past history and merges
that are probably unnecessary to have. A few, small
changesets are nicer to look at :)

Why don't you propose a small evms patch that adds the core
functionality, and worry about getting all of the plugins and other
assorted stuff in later? You will probably get more constructive
comments, as wading through a patch 37956 lines long is a bit difficult.

thanks,

greg k-h